editgroups.cgi doesn't protect the querysharegroup from deletion

RESOLVED FIXED in Bugzilla 3.0

Status

()

RESOLVED FIXED
13 years ago
6 years ago

People

(Reporter: Wurblzap, Assigned: LpSolit)

Tracking

({selenium})

2.23
Bugzilla 3.0
selenium
Bug Flags:
approval +
blocking3.0 +
testcase +

Details

Attachments

(1 attachment)

(Reporter)

Description

13 years ago
editgroups.cgi protects “Special Groups” from deletion by including them into a certain array. The querysharegroup should be included in this array. Additionally, template/en/default/admin/groups/list.html.tmpl should know about this as well and make the protection visible in the bug list, as it does for the other “Special Groups”.
(Reporter)

Updated

13 years ago
Whiteboard: [Good intro bug]
(Assignee)

Updated

12 years ago
Flags: blocking3.0?
Yeah, this should be fixed for 3.0--it could cause database corruption and strange errors.
Flags: blocking3.0? → blocking3.0+
(Assignee)

Comment 2

12 years ago
Created attachment 242913 [details] [diff] [review]
patch, v1

This patch also includes the fix for bug 357429.
Assignee: administration → LpSolit
Status: NEW → ASSIGNED
Attachment #242913 - Flags: review?(mkanat)
(Assignee)

Updated

12 years ago
Whiteboard: [Good intro bug]
Comment on attachment 242913 [details] [diff] [review]
patch, v1

This looks correct to me.

r=mkanat by inspection
Attachment #242913 - Flags: review?(mkanat) → review+
(Assignee)

Updated

12 years ago
Flags: approval?
(Assignee)

Updated

12 years ago
Blocks: 357429
Flags: approval? → approval+
(Assignee)

Comment 4

12 years ago
Checking in editgroups.cgi;
/cvsroot/mozilla/webtools/bugzilla/editgroups.cgi,v  <--  editgroups.cgi
new revision: 1.82; previous revision: 1.81
done
Checking in template/en/default/admin/groups/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/groups/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.10; previous revision: 1.9
done
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

6 years ago
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/qa/4.4/
modified t/test_groups.t
Committed revision 239.

Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/qa/4.2/
modified t/test_groups.t
Committed revision 229.
Flags: testcase+
Keywords: selenium
You need to log in before you can comment on or make changes to this bug.