349951 - incorrect LOG statement for no pollable event

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

http://lxr.mozilla.org/seamonkey/source/netwerk/base/src/nsSocketTransportService2.cpp#376
376         NS_WARN_IF_FALSE(mThreadEvent,
377                 "running socket transport thread without a pollable event");
378         LOG(("running socket transport thread without a pollable event"));

The LOG statement needs to be conditional

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

very low risk patch... just fixes some logging code

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 235171 [details] [diff] [review]
patch

a=beltzner on behalf of drivers for the MOZILLA_1_8_BRANCH

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

HEAD:
Checking in nsSocketTransportService2.cpp;
/cvsroot/mozilla/netwerk/base/src/nsSocketTransportService2.cpp,v  <--  nsSocketTransportService2.cpp
new revision: 1.24; previous revision: 1.23
done

MOZILLA_1_8_BRANCH:
Checking in nsSocketTransportService2.cpp;
/cvsroot/mozilla/netwerk/base/src/nsSocketTransportService2.cpp,v  <--  nsSocketTransportService2.cpp
new revision: 1.20.4.2; previous revision: 1.20.4.1
done