349957 - When adding search plugins, full URL should be displayed

Status: RESOLVED WONTFIX

(Firefox :: Search, defect)

Description

[Jackie Liu]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060823 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060823 BonEcho/2.0b2

When manually adding search plugins of any type, only the [sub]domain is displayed.  The full URL should be displayed as it is in Firefox 1.5.0.6.  Note that the full URL is displayed in search auto discovery.  It seems that the full URL should be displayed even when manually adding plugins.

Reproducible: Always

Steps to Reproduce:
1. Try to add the IMDb search engine from http://mycroft.mozdev.org/quick/imdb.html.  Note that in Site: field of the "Add search engine" dialog that comes up displays "mycroft.mozdev.org"
2. Visit "http://en.wikipedia.org".  Note that search engine autodiscovery is enabled.  Click on the search engine logo with a blue glow.  Note that the full URL of the search plugin is displayed.
3. Do the same as step 1 in Firefox 1.5.0.6. Note that the full URL is displayed which is "http://mycroft.mozdev.org/install.php/6801/IMDb.src".

Actual Results:  
When manually adding search plugins of any type, only the [sub]domain is displayed.

Expected Results:  
When manually adding search plugins of any type, the full URL should be displayed.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #0)
> 2. Visit "http://en.wikipedia.org".  Note that search engine autodiscovery is
> enabled.  Click on the search engine logo with a blue glow.  Note that the full
> URL of the search plugin is displayed.

This only happens because Wikipedia doesn't provide a title attribute on it's <link> element, so we fall back to the URL.

> Expected Results:  
> When manually adding search plugins of any type, the full URL should be
> displayed.

Why?

Comment 2

[Jackie Liu]

Then why doesn't it fall back to just "en.wikipedia.org"?  The full URL has been shown in Firefox 1.5.0.6.  And why not?  

Just wondering, wasn't the change intentional?

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> Then why doesn't it fall back to just "en.wikipedia.org"?  The full URL has
> been shown in Firefox 1.5.0.6.

Because cleaning up the URL wasn't considered important for something that's only used as a fallback.

> And why not?

Changes are made because there is a reason to make them, not because there is no reason not to. Since you're proposing the change, the burden of proof that this is a desirable change is on you.

> Just wondering, wasn't the change intentional?

I'm not sure what you mean.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Re-open if you have a rationale.