349961 - Remove use of explicit native wrappers in session restore service

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Now that bug 345991 is fixed, there should be no need to use explicit wrappers in the session restore components.

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: fix

wrapper removal. works fine on trunk, text is re/stored as usual.

Comment 2

[Simon Bünzli]

Attachment: fix (removing non-working code paths for about:config)

This slightly more comprehensive patch additionally removes the unnecessary and non-working code paths for about:config and doesn't store two references to text areas where one is sufficient.

Dietrich: If you agree with these changes, please re-assign the bug to me and check it in on Trunk for testing. Thanks.

Comment 3

[Simon Bünzli]

Comment on attachment 236612 [details] [diff] [review]
fix (removing non-working code paths for about:config)

Drivers: This low-risk patch removes a broken code path (tracked by bug 350718) and all references to XPCNativeWrappers from SessionStore.

It'd be nice to have in order not to make extension authors looking through the included components for inspiration think that explicit native wrappers are still required.

Comment 4

[Mike Schroepfer]

Can we confirm that these objects are getting properly wrapped w/o the explicit use of native wrappers?

Comment 5

[Simon Bünzli]

(In reply to comment #4)
> Can we confirm that these objects are getting properly wrapped w/o the explicit
> use of native wrappers?

The native wrappers are now guaranteed by bug 345991 and have led to bug 350718 (about:config's filter is no longer saved/restored because the relevant code required the absence of a native wrapper). So yes, we can confirm this.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Are there any benefits to this other than code cleanup?

Comment 7

[Mike Schroepfer]

Comment on attachment 236612 [details] [diff] [review]
fix (removing non-working code paths for about:config)

We are closing in on the RC1 code freeze and are only taking bugs that match the criteria for 181 approvals:

http://developer.mozilla.org/devnews/index.php/2006/08/28/firefox-2gecko-181-approvals-2/

Since this is just code cleanup we are going to skip.  If there is another reason why we should take for the branch please note/re-nom.

Comment 8

[Boris Zbarsky [:bzbarsky]]

For the XPCNativeWrapper parts, not really.  At least not that I can think of.