Allow cairo.h usage in nsSVGUtils.h

RESOLVED FIXED

Status

()

Core
SVG
RESOLVED FIXED
12 years ago
11 years ago

People

(Reporter: tor, Assigned: tor)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

12 years ago
CTM rework is going to need some utility methods in nsSVGUtils that return cairo_matrix_t structures.  As nsSVGUtils::SVGEnabled() is used in the tree in places were pulling in cairo.h would not be appropriate, move that functionality to a global function.
(Assignee)

Comment 1

12 years ago
Created attachment 235261 [details] [diff] [review]
reduce nsSVGUtils.h usage
Assignee: general → tor
Status: NEW → ASSIGNED
Attachment #235261 - Flags: review?(jwatt)
(Assignee)

Updated

11 years ago
Attachment #235261 - Flags: superreview?(roc)
Attachment #235261 - Flags: review?(roc)
Attachment #235261 - Flags: review?(jwatt)
Which places are these?

Don't you have to have a prototype for those callers that isn't in nsSVGUtils.h? I don't see it.
(Assignee)

Comment 3

11 years ago
Whoops, the version of the patch I attached before only diffed {content,layout}/svg.

(In reply to comment #2)
> Which places are these?

content/base, layout/base, layout/build

> Don't you have to have a prototype for those callers that isn't in
> nsSVGUtils.h? I don't see it.

I prototype it in the files that can't include nsSVGUtils.h.

(Assignee)

Comment 4

11 years ago
Created attachment 237337 [details] [diff] [review]
full diff
Attachment #235261 - Attachment is obsolete: true
Attachment #237337 - Flags: superreview?(roc)
Attachment #237337 - Flags: review?(roc)
Attachment #235261 - Flags: superreview?(roc)
Attachment #235261 - Flags: review?(roc)
Attachment #237337 - Flags: superreview?(roc)
Attachment #237337 - Flags: superreview+
Attachment #237337 - Flags: review?(roc)
Attachment #237337 - Flags: review+
(Assignee)

Comment 5

11 years ago
Checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.