350090 - google search sending unofficial code

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[chris hofmann]

Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/2006082303 and recent fr, de appear to be sending 

google search codes that look like

http://www.google.com/search?q=test&ie=utf-8&oe=utf-8&rls=org.mozilla:en-US:unofficial&client=firefox-a

what build foo is needed to send official instead of unofficial and/or when will we flip that switch?  

we ought to do that as soon as possible to get it out of the way.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

See bug 347931 comment 11. That parameter changes depending on --enable-official-branding.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

(since RCs always ship with official branding, this should be taken care of automatically)

Comment 3

[Mike Schroepfer]

I believe this is taken care of with official branding.  Assigning to me to confirm when f2 b2 builds come out...

Comment 4

[Mike Schroepfer]

From the b2 rc2 candiate FR build:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; fr; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2

http://www.google.com/search?q=test+query&ie=utf-8&oe=utf-8&rls=org.mozilla:fr:official&client=firefox-a

Which has the correct official code sent.  So this is in-fact resolved by enable-official-branding.  Resolving fixed.

Comment 5

[chris hofmann]

is it possible that the german build didn't pick up the offical build flag?

https://bugzilla.mozilla.org/show_bug.cgi?id=348021#c9

Comment 6

[chris hofmann]

same for es-ES https://bugzilla.mozilla.org/show_bug.cgi?id=348082#c2

Comment 7

[chris hofmann]

same for google ja search.

but yahoo doesn't seem to work off the build flag to enable the offical code.

https://bugzilla.mozilla.org/show_bug.cgi?id=348024#c1

Comment 8

[Mike Schroepfer]

Chris - can you confirm you buildsIDs?   

As in https://bugzilla.mozilla.org/show_bug.cgi?id=348021#c12 I think you might have a nightly.  I just tried:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X; ja; rv:1.8.1b2) Gecko/20060821 Firefox/2.0b2

Any everything seems fine with Google.

Comment 9

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #7)
> but yahoo doesn't seem to work off the build flag to enable the offical code.

There is no "official" parameter for Yahoo. What are you expecting it to do differently for official builds?

Comment 10

[chris hofmann]

> > but yahoo doesn't seem to work off the build flag to enable the offical code.
>
> There is no "official" parameter for Yahoo. What are you expecting it to do
> differently for official builds?

a ja-JP shows the following URL after a search in a build with offical branding *not* set.

  http://search.yahoo.co.jp/search?p=test&ei=UTF-8&fr=moz2&rls=org.mozilla:ja-JP:official

the "official" code on the end of the search is also shown in the req. spec

  Yahoo! URLs follow this basic formula:

  http://%DOMAIN%/search?p={searchTerms}&ei=UTF-8&fr=%IDENTIFIER%&rls=org.mozilla:en-US:official 

http://wiki.mozilla.org/Firefox2/L10n_Requirements#Search_Plugins

Comment 11

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #10)
> a ja-JP shows the following URL after a search in a build with offical branding
> *not* set.
> http://search.yahoo.co.jp/search?p=test&ei=UTF-8&fr=moz2&rls=org.mozilla:ja-JP:official
> 
> the "official" code on the end of the search is also shown in the req. spec
> 
>   Yahoo! URLs follow this basic formula:
> http://%DOMAIN%/search?p={searchTerms}&ei=UTF-8&fr=%IDENTIFIER%&rls=org.mozilla:en-US:official 

Those requirements didn't exist when I implemented the search service special parameters, at least not publicly. Currently, the en-US Yahoo plugin does not send the "rls" parameter - having it do that would be fairly trivial, since that already was implemented for the Google plugin. What's the value of %IDENTIFIER% supposed to be, though? Currently, it's hardcoded to be "moz2", as in "fr=moz2". See http://lxr.mozilla.org/seamonkey/source/browser/locales/en-US/searchplugins/yahoo.xml .

Comment 12

[Phil Schwan]

(In reply to comment #11)
> >   Yahoo! URLs follow this basic formula:
> > http://%DOMAIN%/search?p={searchTerms}&ei=UTF-8&fr=%IDENTIFIER%&rls=org.mozilla:en-US:official 
> 
> Those requirements didn't exist when I implemented the search service special
> parameters, at least not publicly. Currently, the en-US Yahoo plugin does not
> send the "rls" parameter - having it do that would be fairly trivial, since
> that already was implemented for the Google plugin.

I'm sorry, that shouldn't be there.  I don't know how it survived that long.  I've removed it, you can forget about rls=

> What's the value of %IDENTIFIER% supposed to be, though? Currently, it's
> hardcoded to be "moz2", as in "fr=moz2". See

I believe it's similar to client=firefox in our Google plugin, but I've asked Yahoo to confirm that we're using it correctly.