350094 - Changing 'Weeks in view' pref causes JS error if Multiweek view was not shown before

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Stefan Sitter [:ssitter]]

Changing 'Weeks in view' pref causes JS error if Multiweek view was not shown before

Steps to Reproduce:
1. Start Sunbird and switch to Day, Week or Month view
2. Restart Sunbird
3. Open preferences and change setting for 'Default Weeks to show'

Actual Results:
 Error: aDate has no properties
 Source File: chrome://calendar/content/calendar-decorated-multiweek-view.xml
 Line: 175
Except the error message there is no problem.

Expected Results:
No error message.

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060824 Calendar/0.3a2+

Comment 1

[Stefan Sitter [:ssitter]]

Attachment: Don't refresh if we're not initialized

The pref change calls calDecWeekViewPrefChange() that calls the setter of weeksInView. The setter calls goToDay() that will fail if we're not initialized. This patch adds a simple sanity check. Similar check is done in other places before calling goToDay(), e.g. in calDecWeekViewPrefChange() for other prefs.

Comment 2

[Joey Minta]

Comment on attachment 235294 [details] [diff] [review]
Don't refresh if we're not initialized

r1/r2=jminta

Comment 3

[Joey Minta]

patch checked in.

Comment 4

[Stefan Sitter [:ssitter]]

VERIFIED with Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20060901 Calendar/0.3a2+