Closed
Bug 350149
Opened 18 years ago
Closed 18 years ago
go button is 1 px short on Mac
Categories
(Firefox :: Address Bar, defect)
Tracking
()
VERIFIED
FIXED
Firefox 2
People
(Reporter: beltzner, Assigned: pamg.bugs)
References
Details
(Keywords: fixed1.8.1, Whiteboard: [Fx2 theme change])
Attachments
(2 files)
5.29 KB,
image/png
|
Details | |
1.94 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
I believe this might have broken when we fixed the issue where the URL bar was growing a pixel to accomodate the RSS and SSL buttons. Possibly fixable as part of bug 348138, so I'm tentatively assigning this one to Pam :)
Reporter | ||
Comment 1•18 years ago
|
||
Reporter | ||
Updated•18 years ago
|
Whiteboard: [Fx2 theme change]
Assignee | ||
Comment 2•18 years ago
|
||
Yes, bug 348138 should fix this once I tweak it for Mac too.
Reporter | ||
Comment 3•18 years ago
|
||
K, marking blocking, adding dependency
Depends on: 348138
Flags: blocking-firefox2+
Reporter | ||
Comment 4•18 years ago
|
||
Bug 348138 has been removed from the blocking list, but this still needs to be resolved. Do we just need a larger image here?
Assignee | ||
Comment 5•18 years ago
|
||
Removes padding around Go-button image. Also notices that new image is only 24px high, not 25.
Attachment #235966 -
Flags: review?(mconnor)
Attachment #235966 -
Flags: approval1.8.1?
Comment 6•18 years ago
|
||
Comment on attachment 235966 [details] [diff] [review] CSS fix for Go button height r+a=me on this branch theme fix. thanks Pam!
Attachment #235966 -
Flags: review?(mconnor)
Attachment #235966 -
Flags: review+
Attachment #235966 -
Flags: approval1.8.1?
Attachment #235966 -
Flags: approval1.8.1+
Updated•18 years ago
|
Whiteboard: [Fx2 theme change] → [Fx2 theme change][checkin needed (1.8 branch)]
Assignee | ||
Comment 7•18 years ago
|
||
Landing on branch only.
Status: NEW → RESOLVED
Closed: 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [Fx2 theme change][checkin needed (1.8 branch)] → [Fx2 theme change]
You need to log in
before you can comment on or make changes to this bug.
Description
•