350201 - Location bar shows about:blank after toolbar customization

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Michael Wu [:mwu]]

If the user has about:blank open and then customizes his/her toolbars, the location bar will show about:blank immediately afterwards. The location bar should remain empty, however.

Comment 1

[Michael Wu [:mwu]]

Attachment: Leave urlbar blank for about:blank

Comment 2

[Asaf Romano (gone)]

Comment on attachment 235989 [details] [diff] [review]
Leave urlbar blank for about:blank

I would rather do
gURLBar.value = url == "about:blank" ? "" : url;

r=mano with that fixed.

Comment 3

[Michael Wu [:mwu]]

Attachment: As checked in

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.701; previous revision: 1.700
done

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 236117 [details] [diff] [review]
As checked in

This patch is minimal risk, and fairly obvious.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 236117 [details] [diff] [review]
As checked in

a=beltzner on behalf of 181drivers

Comment 6

[Phil Ringnalda (:philor)]

*** Bug 256460 has been marked as a duplicate of this bug. ***

Comment 7

[Michael Wu [:mwu]]

Branch checkin:
Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.479.2.198; previous revision: 1.479.2.197
done

Comment 8

[Simon Bünzli]

If you compare this patch with the code at http://tinyurl.com/rbyvl , does the call to SetPageProxyState really not do any harm here while it does in handleURLBarRevert?

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

http://litmus.mozilla.org/show_test.cgi?searchType=by_id&id=4521

in-litmus+

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007102704 Minefield/3.0a9pre

and Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9a9pre) Gecko/2007102721 Minefield/3.0a9pre