350205 - visitLink is browser specific (links in Thunderbird's About dialog don't work)

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

visitLink depends on openNewWindowWith, which is browser-specific. It shouldn't do that.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Comment on attachment 235426 [details] [diff] [review]
patch

"else" on a separate line, please.

r=mano.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/globalOverlay.js 	1.27

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 235426 [details] [diff] [review]
patch

This would be a nice-to-have for users of this function that aren't browsers (Sunbird and Thunderbird). The risk of regression is low - this only affects links in the about dialog, and uses the same code that the text-link binding has always used to open links (like the one in the EM, for example).

Comment 5

[:Gavin Sharp [email: [e-mail]]]

Note: this is a refinement of the patch for bug 349841, and it doesn't regress that bug.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 235426 [details] [diff] [review]
patch

a=beltzner on behalf of 181drivers

Comment 7

[:Gavin Sharp [email: [e-mail]]]

mozilla/toolkit/content/globalOverlay.js 	1.18.8.8

Comment 8

[Adam Guthrie]

*** Bug 349980 has been marked as a duplicate of this bug. ***