350242 - "delete 0x11.x" decompiles incorrectly

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P2)

Description

[Jesse Ruderman]

> function () { delete 0x11.x }
function () { delete 17.x; }

> function () { delete 17.x; }
syntax error

I guess hex numbers end at a period but decimal numbers don't.  Adding parens around "153" would fix this.

Comment 1

[Brendan Eich [:brendan]]

Attachment: fix

See also bug 333541 (the jsopcode.tbl changes made there did not affect the prop- and elem-format JSOP_DEL* ops).

/be

Comment 2

[Brendan Eich [:brendan]]

*** Bug 350241 has been marked as a duplicate of this bug. ***

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 235535 [details] [diff] [review]
fix

sr=shaver

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 235535 [details] [diff] [review]
fix

This follows existing case handling for other "lvalue" operators than delete, so it's as safe as those pre-existing cases.  It would be good to get this into js1.7, both to avoid hacks in Jesse's testers, and for decompiler-dependent clients (Venkman's debug-pretty-printed mode, Ebay scripts that decompile/edit/compile functions...).

/be

Comment 5

[Brendan Eich [:brendan]]

Fixed on trunk.

/be

Comment 6

[Mike Schroepfer]

Comment on attachment 235535 [details] [diff] [review]
fix

a=schrep/beltnzer for drivers.

Comment 7

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 8

[Bob Clary [:bc] (inactive)]

Checking in regress-350242.js;
/cvsroot/mozilla/js/tests/js1_5/Regress/regress-350242.js,v  <--  regress-350242.js
initial revision: 1.1

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed 1.8 20060828 windows/mac*/linux

Comment 10

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20060830 windows/mac*/linux