350245 - Updater.app forgets to reload the main app under Rosetta if it was originally launched with translation

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Code was added to MacLaunchHelper.m to ensure that apps loaded under Rosetta would restart under Rosetta. That change never made it to Updater.app.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Attachment: Patch v1.0

Comment 2

[Mike Schroepfer]

per beltnzer/schrep weekend triage we'd take a patch but this is not a ff2 blocker.

Comment 3

[Mark Mentovai]

Comment on attachment 235490 [details] [diff] [review]
Patch v1.0

I could swear I already commented on this patch!

Anyway, this is good for Updater.app, but it relies on the launching process to be running translated in order to launch the child translated.  We don't special-case the Mac in nsUpdateDriver.cpp, so the native x86 version of Updater.app will always be launched, even by ppc code running translated under Rosetta.  We should make nsUpdateDriver.cpp take advantage of the existing LaunchChildMac(), and fix LaunchChildMac to launch something from an argument instead of always launching [[NSBundle mainBundle] executablePath].

So, r+ on the Updater.app portion, but I don't think it'll do what you expect until nsUpdateDriver is changed.

Comment 4

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Fixed on trunk. I'll file a bug re: comment 3.

Comment 5

[Ben Turner (not reading bugmail, use the needinfo flag!)]

(In reply to comment #4)
> Fixed on trunk. I'll file a bug re: comment 3.

Filed bug 350622 and bug 350623.