350257 - "increment" in numberbox is doubled if it's in chrome

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[O. Atsushi (Torisugari)]

If the xul file has the chrome privilege, both "up" event
handler and "onup" hadler will be called on pusing up button.
So they increments the number twice in total.

steps to reproduce:
1. Create a xul file with <textbox type="number" increment="10"/>
2. Unzip browser.jar, put the file anywhere and rezip it.
3. Access the xul file with chrome://.../ URI
4. Push "Up" button.

Expected result:
0 -> 10

Actual result:
0 -> 20

This is reproducible on Linux and Windows, and when I wrote
a extension as well. However, it's not reproducible if the 
URL is "file://..." or "http://..."

Comment 1

[Neil Deakin]

Attachment: fix up/down events

How strange. Remove the extra event handlers.

Comment 3

[Neil Deakin]

Neil, review this bug! ;)

Comment 4

[[e-mail]]

The question is, will you refix it correctly when bug 350334 gets fixed?

Comment 5

[[e-mail]]

Comment on attachment 235512 [details] [diff] [review]
fix up/down events

Now that bug 350334 is fixed please remove the "other" extra event handlers ;-)

Comment 6

[Neil Deakin]

Attachment: remove extra event handlers

Comment 7

[[e-mail]]

Comment on attachment 261604 [details] [diff] [review]
remove extra event handlers

BTW does <textbox type="number"> work with toolkit's <prefwindow> ?
(XPFE's wsm doesn't seem to like it.)

Comment 8

[O. Atsushi (Torisugari)]

(In reply to comment #7)
> (From update of attachment 261604 [details] [diff] [review])
> BTW does <textbox type="number"> work with toolkit's <prefwindow> ?
> (XPFE's wsm doesn't seem to like it.)
>

Yes, numberbox in prefwindow should work fine on Firefox. I haven't
tested this XUL element recently, but when I filed this bug, I was
writing something <textbox type="number" pref="foo"/> in prefwindow.

Comment 9

[Phil Ringnalda (:philor)]

Bleah. Is there a bug on making wsm play nice, or alternately one on moving mail account management to something that doesn't use it, that I can be blocked on bug 376975 by?

Comment 10

[[e-mail]]

(In reply to comment #9)
>Is there a bug on making wsm play nice, or alternately one on moving mail
>account management to something that doesn't use it
Mail account management never used it (wsm doesn't support multiple accounts).

Comment 11

[Robert Sayre]

Is there a test covering this in the widget suite?

Comment 12

[O. Atsushi (Torisugari)]

Thanks. ->v