Closed Bug 350258 Opened 18 years ago Closed 18 years ago

"addons.mozilla.org" hardcoded into extensions.dtd

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
1.8 Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: bent.mozilla, Assigned: bent.mozilla)

Details

(Keywords: fixed1.8.1, late-l10n)

Attachments

(1 file, 1 obsolete file)

Patch v2.0
3.01 KB, patch
robert.strong.bugs
: review+
mconnor
: approval1.8.1+
Details | Diff | Splinter Review 
The EM UI is included in toolkit, so we need to get these tooltips out of there.
Target Milestone: --- → Firefox 2
Version: unspecified → 2.0 Branch
Attached patch Patch v1.0 (obsolete) — — Splinter Review 
Just plain chop it?
Assignee: nobody → bent.mozilla
Status: NEW → ASSIGNED
Attachment #235505 - Flags: review?(robert.bugzilla)
I doubt this will make Fx2, as l10n freeze has already happened.
Keywords: late-l10n
Hey Ben, I'm going to run by beltzner if he'd have a problem with just removing the tooltip from the xul since it wouldn't have an l10n impact.
(In reply to comment #3)
> Hey Ben, I'm going to run by beltzner if he'd have a problem with just removing
> the tooltip from the xul since it wouldn't have an l10n impact.
> 

Sounds fine to me. Thanks!
(In reply to comment #4)
Chatted with beltzner, he agreed that removing the tooltip is appropriate. Patch in a sec.
Attached patch Patch v2.0 — — Splinter Review 
Remove the tooltip.
Attachment #235505 - Attachment is obsolete: true
Attachment #236124 - Flags: review?(robert.bugzilla)
Attachment #235505 - Flags: review?(robert.bugzilla)
Attachment #236124 - Flags: review?(robert.bugzilla) → review+
Fixed on trunk
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment on attachment 236124 [details] [diff] [review]
Patch v2.0

Requesting branch approval.
Attachment #236124 - Flags: approval1.8.1?
Shouldn't the patch have also removed getExtensions.tooltip and getThemes.tooltip from extension dtd? - at least on trunk at any rate.

http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/toolkit/locales/en-US/chrome/mozapps/extensions/extensions.dtd&rev=1.18&mark=101,103#101
For the trunk sure. I'm planning on re-working this for 3.0 so I'm not too concerned about it.
Comment on attachment 236124 [details] [diff] [review]
Patch v2.0

a=mconnor on behalf of drivers for 1.8 branch checin
Attachment #236124 - Flags: approval1.8.1? → approval1.8.1+
fixed on branch!
Keywords: fixed1.8.1
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: