350287 - Need a webcal:// protocol handler (for sunbird and lightning)

Status: RESOLVED FIXED

(Calendar :: Internal Components, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

We need a webcal:// protocol handler, and have it registered in the OS.

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: add it

this patch add the handler. It doesn't register it with the OS yet.

Comment 2

[Matthew (lilmatt) Willis]

Comment on attachment 235569 [details] [diff] [review]
add it

> Index: base/src/Makefile.in
> +    calProtocolHandler.js \
Nit: Please insert this in the list in alpha order rather than at the end. EXTRA_SCRIPTS is only used to package the pseudo-modules, so order isn't used for loading or anything.

> Index: locales/en-US/chrome/calendar/calendar.dtd
> +<!ENTITY calendarproperties.autorefresh.label "Refresh calendar every N minutes">
This shouldn't have made it into the patch. :)

> Index: base/src/calProtocolHandler.js
> + * The Original Code is mozilla calendar code.
> + *
> + * The Initial Developer of the Original Code is
> + * Michiel van Leeuwen <[e-mail]>.
More silly nits: Capitalization on Mozilla Calendar, and add 2 spaces before your name (3 spaces total between * and M) to match most other files.

Otherwise, this appears to work, although I don't have a webcals:// URL to test with.

Bonus points for changing the default port of webcal to 80 (rather than 8080)

Do we still need all the "BogusChannel" stuff in /m/c/resources/content/calendarService.js?  

r1=lilmatt

Comment 3

[Matthew (lilmatt) Willis]

Setting to mvl since he's the one with the patch

Comment 4

[Matthew (lilmatt) Willis]

Nominating for blocking0.3 as this blocks a blocker (bug 338059)

Comment 5

[Matthew (lilmatt) Willis]

blocking0.3+ since there's a blocker that needs this to be resolved

Comment 6

[Matthew (lilmatt) Willis]

> (From update of attachment 235569 [details] [diff] [review] [edit])

One other thing:
We'll need to add this to /m/c/installer/windows/packages-static.

I think we ought to replace all the \js\calFoo.js entries in that file with
\js\*  so we stop forgetting about this.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 235569 [details] [diff] [review]
add it

Looks good.  Nit: the use of "an" rather than "a" as a prefix on variables that start with a vowel seems out of place, since "a" is supposedly short for "argument".  r2=dmose with that fixed and the changes suggested by lilmatt.

Comment 8

[Michiel van Leeuwen (email: mvl+moz@)]

patch (with updates) checked in. Filed bug 352566 for the OS registration.