350313 - unneccessary refreshing events from local calendars on startup

Status: RESOLVED WORKSFORME

(Calendar :: Calendar Frontend, defect, P1)

Description

[Damian Szczepanik]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060825 Calendar/0.3a2+

remote calendars are refreshing every time you launch Sunbird
events appears after 1-3 seconds, however events from local (Home) calendar are also refreshing and there is effect of blinking

Reproducible: Always

Steps to Reproduce:
1. add remote calendar with events
2. restart Sunbird
Actual Results:  
events from local calendar are displayed for 1-2 seconds, then disappear and are showing again - blinking

Expected Results:  
events from local calendars should not be refreshed

when you have remote calendar but events are not displayed (because you unchecked this calendar in calendar panel) works fine

Comment 1

[Damian Szczepanik]

similar to bug 216251 - when click "Reload remote calendars" local events blink as well

Comment 2

[Joey Minta]

If someone could track down more specifically what the actual 'refresh' is here, I'd be very interested in the data.  I was pretty sure I eliminated the duplicate getItems() calls previously, but I may have been mistaken.  Logging all the calls to a particular provider's getItems method should show whether this is the case.

The following function may prove useful:
function debugGetStack(aDepth) {
    var depth = aDepth || 5;
    var stack = "";
    var frame = arguments.callee.caller;
    for (var i = 1; i <= depth; i++) {
        stack += i+": "+ frame.name+ "\n";
        frame = frame.arguments.callee.caller;
        if (!frame) {
            break;
        }
    }
    return stack;
}

On a side note, it may be interesting to insert perf-debugging code into our actual codebase, to help others diagnose these problems.

Comment 3

[Damian Szczepanik]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20061030 Calendar/0.4a1

still can be reproduce

Comment 4

[Daniel Boelzle [:dbo]]

WFM (on Mac); does this still occur? There's no flickering, only the scroll position change on startup (week view). I've added dumps to providers' refresh function, but none is called more than once on startup.

Comment 5

[Dan Mosedale (:dmosedale, :dmose)]

I'm not seeing this on current nightlies, but I'm almost certain I was until a week or two ago.  Interestingly, making various changes (notably dragging existing events) to CalDAV calendars just recently stopped showing up immediately, and requiring a refresh (or maybe a reload?) to become visible.  I'm wondering if a recent landing fixed this bug while introducing that regression.

Comment 6

[Philipp Kewisch [:Fallen][☁️📆]]

Dan, have you been able to reproduce the startup issue? I think the not immediate changes to events was fixed in a different bug.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

Nope, this is continuing to work for me.  Resolving as such.