350335 - Editable trees: clicking anywhere outside the cell being edited should go out of the editing mode

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Nickolay_Ponomarev]

STR:
1. Open attachment 235591 [details] [edit] in the browser (can't test in chrome due to bug
350332)
2. Double click the first cell
3. Click anywhere outside the cell

Actual results:
The textbox does not disappear. It's hard to figure out how to get rid of the textbox using the mouse (you can double-click the cell being edited).

Expected results:
The textbox disappears when user clicks anywhere in the tree outside the cell.

Comment 1

[Nickolay_Ponomarev]

Note that clicking inside an editable tree column does exit the edit mode, but if you click the column below the actual content, the edit mode is retained.

Comment 2

[Nickolay_Ponomarev]

Attachment: possible patch

I don't see anything wrong with calling stopEditing in the left click handler.

A different question is whether a right-click should also dismiss the edit mode.

Comment 3

[Neil Deakin]

The blur handler should be stopping edit mode, so we should fix the issue there instead.

Comment 4

[Nickolay_Ponomarev]

Comment on attachment 235610 [details] [diff] [review]
possible patch

I didn't do it in the blur listener, because invoking various menus (either top-level or context) doesn't stop editing on Windows (and shouldn't do it). I now see that the blur event is not in fact dispatched  in those cases, so this might just work.

Comment 5

[Nickolay_Ponomarev]

v.