Closed Bug 350336 Opened 18 years ago Closed 18 years ago

In <searchWidgets.xml>, Strict "Warning: assignment to undeclared variable gPicker"

Categories

(MailNews Core :: Filters, defect)

Product:
MailNews Core
Component:
Filters
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla1.8.1

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

(Keywords: verified1.8.1)

Attachments

(1 obsolete file) 

[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1b2) Gecko/20060826 SeaMonkey/1.1a] (nightly) (W98SE)

1. Tools > Message Filters... > Edit
[
Warning: assignment to undeclared variable gPicker
Source File: chrome://messenger/content/searchWidgets.xml
Line: 244
]
Same code on trunk, from
[
1.1    	scott%scott-macgregor.org	2005-08-02 13:14	 	Bug #294094 --> Redesign filter actions to simplify the Filter Rule Dialog

r=neil
sr=bienvenu
a=chofmann
]

This line seems to have been useless from the beginning.
Component: MailNews: Main Mail Window → MailNews: Filters
Depends on: 294094
OS: Windows 98 → All
Product: Mozilla Application Suite → Core
Hardware: PC → All
Target Milestone: --- → mozilla1.8.1
Version: 1.8 Branch → Trunk
Removes this code line.
Assignee: mail → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #235623 - Flags: superreview?(mscott)
Attachment #235623 - Flags: review?(mscott)
Attachment #235623 - Flags: approval-thunderbird2?
Comment on attachment 235623 [details] [diff] [review]
(Av1) <searchWidgets.xml>
[Checkin: Comment 4 & 6]

Thanks for the patch.

I'm going to minus for tb2 for right now. But if this bakes for a while on the trunk and you really want it on the branch, ask again.
Attachment #235623 - Flags: superreview?(mscott)
Attachment #235623 - Flags: superreview+
Attachment #235623 - Flags: review?(mscott)
Attachment #235623 - Flags: review+
Attachment #235623 - Flags: approval-thunderbird2?
Attachment #235623 - Flags: approval-thunderbird2-
Comment on attachment 235623 [details] [diff] [review]
(Av1) <searchWidgets.xml>
[Checkin: Comment 4 & 6]


Checkin: {
2006-10-10 06:39	bugzilla%standard8.demon.co.uk 	mozilla/mailnews/base/search/resources/content/searchWidgets.xml 	1.13
}
Attachment #235623 - Attachment description: (Av1) <searchWidgets.xml> → (Av1) <searchWidgets.xml> [Checkin: Comment 4]
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment on attachment 235623 [details] [diff] [review]
(Av1) <searchWidgets.xml>
[Checkin: Comment 4 & 6]

'approval&#8209;thunderbird2=?'
Asking again, after a 10 days Trunk baking.
Can you check it in too ?
Attachment #235623 - Flags: approval-thunderbird2- → approval-thunderbird2?
Attachment #235623 - Flags: approval-thunderbird2? → approval-thunderbird2+
Comment on attachment 235623 [details] [diff] [review]
(Av1) <searchWidgets.xml>
[Checkin: Comment 4 & 6]


Checkin: {
2006-10-21 08:16	bugzilla%standard8.demon.co.uk 	mozilla/mailnews/base/search/resources/content/searchWidgets.xml 	1.3.2.9 	MOZILLA_1_8_BRANCH
}
Attachment #235623 - Attachment description: (Av1) <searchWidgets.xml> [Checkin: Comment 4] → (Av1) <searchWidgets.xml> [Checkin: Comment 4 & 6]
Attachment #235623 - Attachment is obsolete: true
Blocks: 294094
No longer depends on: 294094
Keywords: fixed1.8.1
[Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8.1) Gecko/20061022 SeaMonkey/1.1b] (nightly) (W98SE)

V.Fixed on MOZILLA_1_8_BRANCH.
Keywords: fixed1.8.1 → verified1.8.1
Product: Core → MailNews Core
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: