MOZ_XMLEXTRAS(--disable-xmlextras) not used by toolkit

RESOLVED INVALID

Status

()

RESOLVED INVALID
12 years ago
2 years ago

People

(Reporter: romaxa, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

12 years ago
MOZ_XMLEXTRAS option supposed to be disabled with --disable-xmlextras configure option, but toolkit/library libxul-config.mk and nsStaticXULComponents.cpp not use this define...  and linking failed...

Patch in attachment
(Reporter)

Comment 1

12 years ago
Created attachment 235630 [details] [diff] [review]
BUILDFIX
Attachment #235630 - Flags: first-review?(timeless)

Comment 2

12 years ago
Comment on attachment 235630 [details] [diff] [review]
BUILDFIX

xmlextras isn't realistically optional especially for people who care about google apps, but that should be configurator's problem
Attachment #235630 - Flags: first-review?(timeless) → first-review+
(Reporter)

Comment 3

12 years ago
(In reply to comment #2)
> (From update of attachment 235630 [details] [diff] [review])
> xmlextras isn't realistically optional especially for people who care about
> google apps, but that should be configurator's problem
> 
I don't ask to disable xmlextras by default, I just don't want to have problem with building libxul when MOZ_XMLEXTRAS  disabled
(Reporter)

Comment 4

12 years ago
Any superreview?

Comment 5

12 years ago
Comment on attachment 235630 [details] [diff] [review]
BUILDFIX

We should not have the --disable-xmlextras build option. We do not want to ever disable it, even in the smallest embedding profile. This bug is either WONTFIX or should be morphed to remove the flag altogether. See http://wiki.mozilla.org/Gecko:Small_Device_Support
Attachment #235630 - Flags: first-review+ → first-review-

Comment 6

12 years ago
http://wiki.mozilla.org/Gecko:Small_Device_Support lists 
XMLHttpRequest, DOMParser, and DOMSerializer. But those have been moved from mozilla/extensions/xmlextras/base to mozilla/content/base by bug 324865.
So what about the rest? Should we fix the option to turn it off (this bug), or remove --disable-xmlextras and the MOZ_XMLEXTRAS ifdefs?
(Reporter)

Comment 7

12 years ago
I think we have to remove this option, because it useless already
 

Comment 8

2 years ago
MOZ_XMLEXTRAS no longer exists.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.