350405 - tests should be auto-updated

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[:Gavin Sharp [email: [e-mail]]]

Today, the patch in bug 350268 landed, which caused made trailing brackets a fatal error. The startup-test.html file used for the Ts test (mozilla/tools/performance/startup/startup-test.html) contained an extra trailing bracket, so this turned all the tinderboxen that startup tests orange. I checked in a fix to the startup-test.html file in CVS, but that change wasn't propagated to all the tinderboxen because they apparently don't auto-update the test files.

The files used for tests that are in CVS should be auto-updated so that this problem doesn't happen again.

Comment 1

[J. Paul Reed [:preed]]

rhelmer said he updated the following machines:

Firefox
  prometheus-vm
  bl-bldxp01

SeaMonkey
  lhasa
  luna (note - doesn't seem to have cltbld's SSH key)
  planetoid
  bm-xserve02

Camino
  pawn
  maya

SeaMonkey-Ports
  balsa-trunk

*Most* (but not all) of these are old machines, some of which (pawn/maya) aren't on Tinderbox auto-update (to say nothing of auto-test update).

I'm going to kick this over to T.R. to look; I'd like to:

-- Add some code to the auto-update stuff so that we can specify specific list*s* of directories to auto-update

-- Make sure that all the tinderboxen have this variable set correctly.

-- Clean up mozilla/tools on the various tinderboxen.

TR: come find me when you'd like to start on this and we can go through all the details.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

bm-xserve02 and creature-vm are still orange on the SeaMonkey tree, could it be that the startup-test.html file wasn't updated on those machines/trees?

Comment 3

[T.R. Fullhart]

preed suggests having the auto-update code be configured with a ":" separated (like PATH) list of dirs that it should run "cvs update" in.

Comment 4

[T.R. Fullhart]

Attachment: multi-directory tinderbox update patch

This patch to mozilla/tools/tinderbox/multi-tinderbox.pl allows you to configure the TBOX_CLIENT_CVS_DIR environment variable with a syntax like "dir1:dir2:dir3" to have tinderbox client update several directories.

Comment 5

[J. Paul Reed [:preed]]

Comment on attachment 236309 [details] [diff] [review]
multi-directory tinderbox update patch

Other than minor style changes we discussed, r=preed.

Comment 6

[T.R. Fullhart]

Attachment: [checked in] multi-directory tinderbox update patch

Updated variable names and spacing to match styles in the rest of the file per comments from reviewer.

Comment 7

[T.R. Fullhart]

Attachment: tinderbox host dot-files

This is a patch to the dotfiles we are trying to standardize on for the tinderboxen. This patch makes the tinderbox client update the performance test directory as well as the tinderbox directory. This patch requires that the multi-directory update patch be applied to tinderbox first.

Comment 8

[J. Paul Reed [:preed]]

Comment on attachment 236418 [details] [diff] [review]
tinderbox host dot-files

Looks good!

Comment 9

[J. Paul Reed [:preed]]

Checked in the Tinderbox part:

Checking in multi-tinderbox.pl;
/cvsroot/mozilla/tools/tinderbox/multi-tinderbox.pl,v  <--  multi-tinderbox.pl
new revision: 1.14; previous revision: 1.13
done

Comment 10

[J. Paul Reed [:preed]]

Taking TR's bug; I'll retriage these shortly.

Comment 11

[J. Paul Reed [:preed]]

Reassigning bugs I'm not actively working on back into the triage pool.

Comment 12

[J. Paul Reed [:preed]]

To be clear, the rest of this bug is just setting the correct environment variables on all the tinderboxen; the code changes are all checked in.

Comment 13

[Chris Cooper [:coop] (he/him)]

I'll sign up to make these changes.

Comment 14

[Chris Cooper [:coop] (he/him)]

I'll be making these changes today. Below is the list of machines that are actually running Tp/Ts that I will be updating. Please let me know if I've missed any. 

There will be quick hiccups on each machine as I restart tinderbox to pickup the change.

build network
=============
bl-bldlnx01
bl-bldlnx03
bl-bldxp01
bm-xserve02
bm-xserve04
bm-xserve08

community network
=================
cb-sea-linux-tbox
cb-sea-win32-tbox
cb-xserve02
cb-xserve01

Comment 15

[Chris Cooper [:coop] (he/him)]

It turns out we were already dodging around this by setting TBOX_CLIENT_CVS_DIR to /builds/tinderbox/mozilla/tools on all these boxes.

cc-ing mento: the Camino tinderbox (cb-xserve01) doesn't currently have TBOX_CLIENT_CVS_DIR set. I didn't want to set it in case he was relying on local changes and would end up with conflicts. May also want to get boxset and maya updating like this too if they aren't already.

Comment 16

[Mark Mentovai]

Coop, on all three of our tinderboxen, we set the TBOX_CLIENT_CVS_DIR environment variable in multi-config.pl.  That seemed like a better place to configure something that multi-tinderbox uses than .bashrc.

Our tinderboxen do all properly update their tinderbox scripts.