Closed Bug 350423 Opened 18 years ago Closed 18 years ago

problems with the image in the "tbird thinks this message might be a scam" / "blocking remote images" bar

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird2.0

People

(Reporter: moco, Assigned: mscott)

References

Details

(Keywords: fixed1.8.1)

Attachments

(4 files)

problems with the image in the "tbird thinks this message might be a scam" bar

screen shot coming.

I'm using version 2 alpha 1 (20060816) on mac.  (hmm, when I do check for updates, none are found.)
> hmm, when I do check for updates, none are found.

still no updates, and I am running the build that I should be getting updates.

scott / paul:  do you know if there are any AUS issues with mac tbird branch nightlies?
(In reply to comment #2)
> > hmm, when I do check for updates, none are found.
> 
> still no updates, and I am running the build that I should be getting updates.
> 
> scott / paul:  do you know if there are any AUS issues with mac tbird branch
> nightlies?

According to http://users.ox.ac.uk/~clar0239/upwatch/latest/, I don't see any current issues with Tbird 1.8 nightly updates.

What's the full build ID of the build you're trying to update? Are you sure it's checking the nightly channel?
> According to http://users.ox.ac.uk/~clar0239/upwatch/latest/, I don't see any
> current issues with Tbird 1.8 nightly updates.

wow, that's a useful page.

> What's the full build ID of the build you're trying to update? Are you sure
> it's checking the nightly channel?

my user agent is Thunderbird 2.0a1 (Macintosh/20060816) and app.update.channel is nightly.

I'll try setting the appropriate app.update.log.* prefs to see if I can tell what's going on.
after setting the logging prefs, I see this in my console:

update url: https://aus2.mozilla.org/update/1/Thunderbird/2.0a1/2006081605/Darwin_ppc-gcc3/en-US/nightly/update.xml

checkForUpdates: sending request to https://aus2.mozilla.org/update/1/Thunderbird/2.0a1/2006081605/Darwin_ppc-gcc3/en-US/nightly/update.xml

onLoad: request completed downloading document

Updates available: 0

Going to https://aus2.mozilla.org/update/1/Thunderbird/2.0a1/2006081605/Darwin_ppc-gcc3/en-US/nightly/update.xml

gives me <updates></updates>

I'd expect there to be at least one <update> there, taking me to the latest nightly.

maybe 8/16 is "too long ago" for nightlies and the update.xml has been removed?
(In reply to comment #5)
> after setting the logging prefs, I see this in my console:
> 
> update url:
> https://aus2.mozilla.org/update/1/Thunderbird/2.0a1/2006081605/Darwin_ppc-gcc3/en-US/nightly/update.xml

Hrm... I think the bigger problem here is that those builds are UB (I think?), but the update URL is using a PPC only platform.

Note that:

https://aus2.mozilla.org/update/1/Thunderbird/2.0a1/2006081605/Darwin_Universal-gcc3/en-US/nightly/update.xml

gives the right update.

Do the current nightlies have this problem? It may be that we fixed updates, and older nightlies will not get updates because they're checking the wrong platform.
going back to the original problem.

The image only seems to have problems on the branch. the trunk shows the phishing icon correctly. 
It looks like the new firefox theme on the branch altered the dimensions of the icon we use for the phishing bar. And those changes haven't gone into the trunk yet (oops) which is why it still works on the trunk. 
Status: NEW → ASSIGNED
The toolkit icon we use for the phishing indicator is now 24px x 24 px on the branch only.
Attachment #236876 - Flags: superreview?(sspitzer)
Comment on attachment 236876 [details] [diff] [review]
(branch only) the fix

sr=sspitzer, acting as mailnews sr while bienvenu is away
Attachment #236876 - Flags: superreview?(sspitzer) → superreview+
Keywords: fixed1.8.1
Target Milestone: --- → Thunderbird2.0
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
scott, I've updated to version 2 alpha 1 (20060906) and I still see this bug.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
That's odd, I just updated to today's nightly as well on the branch and it's working now. But I do see an odd flicker before the icon loads in the phishing bar. Hmmm....
ah!  the "tbird thinks this message might be a scam" image is ok, but the image used for remote images ("to protect your privacy, Tbird has blocked remote images in this message") has the original problem.

Sorry for the confusion.

do you want a new bug, or should we re-use this bug?
Summary: problems with the image in the "tbird thinks this message might be a scam" bar → problems with the image in the "tbird thinks this message might be a scam" / "blocking remote images" bar
we can re-use this one. It's probably the same problem.
I also searched through lxr to see where else pinstripe is using console-toolbar.png and didn't find any other spots.
ok, this 2nd patch is now on the branch as well. Re-closing. Good catch Seth!
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
*** Bug 351115 has been marked as a duplicate of this bug. ***
I just updated to version 2 alpha 1 (20060908), and this is verified fix.  Thanks scott!
Status: RESOLVED → VERIFIED
Unfortunately, that wasn't a "branch-only" change, just a "branch-first" change, so now the trunk needs the same again.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Attached patch Both, for trunkSplinter Review
Never let it be said that I'll shy away from a trivial patch.
Attachment #246248 - Flags: review?(mscott)
Comment on attachment 246248 [details] [diff] [review]
Both, for trunk

Ah thanks Phil.
Attachment #246248 - Flags: review?(mscott) → review+
Fixed on trunk (fortunately, without my "242px" typo).
Status: REOPENED → RESOLVED
Closed: 18 years ago18 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: