Closed Bug 350452 Opened 18 years ago Closed 18 years ago

Tidy up and re-enable system feed reader detection

Categories

(Firefox Graveyard :: RSS Discovery and Preview, defect, P2)

Product:
Firefox Graveyard
Component:
RSS Discovery and Preview
Platform:
x86
Windows XP
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 2

People

(Reporter: asaf, Assigned: asaf)

References

Details

(Keywords: fixed1.8.1)

Attachments

(4 files, 1 obsolete file)

preview page part
4.87 KB, patch
mconnor
: review+
Details | Diff | Splinter Review
as checked in
7.05 KB, patch
Details | Diff | Splinter Review
trunk patch
10.51 KB, patch
Details | Diff | Splinter Review
the part i forgot to checkin...
1.50 KB, patch
Details | Diff | Splinter Review 
Tidy up and re-enable system feed reader detection.

We've disabled system feed reader detection in bug 346009 in order to land the new UI at the time for b2.
Status: NEW → ASSIGNED
Flags: blocking-firefox2?
Priority: -- → P2
This re-enables the preview page part and fixes a couple of issue to get it working...

TBD: preferences dialog.
Attachment #235735 - Flags: review?(mconnor)
Attachment #235735 - Flags: review?(mconnor) → review+
Flags: blocking-firefox2? → blocking-firefox2+
Attached patch preferences pane part (obsolete) — — Splinter Review 

        Attachment #236336 -
        Flags: review?(mconnor)

    
    

    
  
Comment on attachment 236336 [details] [diff] [review]
preferences pane part

r+a=me, this is branch only  and can't bake on trunk.  please get both patches in ASAP

        Attachment #236336 -
        Flags: review?(mconnor)

        Attachment #236336 -
        Flags: review+

        Attachment #236336 -
        Flags: approval1.8.1+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        as checked in
        — 
          — Splinter Review
      

    


  
1.8 branch:
mozilla/browser/components/preferences/feeds.js 1.1.2.4
mozilla/browser/components/preferences/feeds.xul 1.1.2.4

        Attachment #236336 -
        Attachment is obsolete: true

    
  
Keywords: fixed1.8.1

    
    

    
  
Comment on attachment 235735 [details] [diff] [review]
preview page part

mozilla/browser/components/feeds/src/FeedWriter.js 1.2.2.15

    
    

    
  
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060901 BonEcho/2.0b2 ID:2006090116

with XP default Theme.
http://img176.imageshack.us/img176/8335/preffi3.jpg

on 2006090103, no scroll-bar, no cut-off.

    
    

    
  
Please file a bug.

    
    

    
  
(In reply to comment #7)
> Please file a bug.
> 

bug 351133

    
    

    
  

      
      
      
      

        Attached patch
          
          
        trunk patch
        — 
          — Splinter Review
      

    


  
mozilla/browser/components/preferences/feeds.js 1.4
mozilla/browser/components/preferences/feeds.xul 1.4

    
  
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED

    
    

    
  


  
checked in now on branch:
mozilla/browser/components/preferences/feeds.js 1.1.2.6

will also check-in on trunk RSN.

    
    

    
  
mozilla/browser/components/preferences/feeds.js 1.6

    
  
Depends on: 351133

    
  
Product: Firefox → Firefox Graveyard

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: