350466 - Arrow icons in tab strip scroll buttons not centered vertically

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[ronin.achilles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060828 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060828 BonEcho/2.0b2

https://bugzilla.mozilla.org/show_bug.cgi?id=348335 (Tabstrip scroll arrows no longer look disabled when there's no where to scroll) was checked in today. 

The arrow on the Scroll Buttons are not aligned vertically anymore. They have shifted upwards.

Please see the screenshot of the problem.

Reproducible: Always

Comment 1

[ronin.achilles]

Attachment: Screenshot showing the vertically misaligned arrow on Scroll Button

Screenshot showing the problem.

Comment 2

[ronin.achilles]

Requesting to Block Fx2

Comment 3

[(not reading, please use [e-mail] instead)]

asaf, I fixed this on pinstripe with my last checkin to browser.css

do you mind if I take this for winstripe?

Comment 4

[(not reading, please use [e-mail] instead)]

the fix to pinstripe was:
            
.tabbrowser-arrowscrollbox > .scrollbutton-up > .toolbarbutton-icon {    
  margin-top: 4px;                  
}                                                                            

.scrollbutton-rel-box > .scrollbutton-down > .toolbarbutton-icon {           
  margin-top: 4px;                                                              
}                                                                               

Comment 5

[(not reading, please use [e-mail] instead)]

Attachment: patch

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: screen shot after the patch

Comment 7

[Asaf Romano (gone)]

Comment on attachment 236492 [details] [diff] [review]
patch

thanks, r=mano.

Comment 8

[Mike Connor [:mconnor]]

Comment on attachment 236492 [details] [diff] [review]
patch

a=mconnor on behalf of drivers for 1.8 branch checkin

Comment 9

[(not reading, please use [e-mail] instead)]

fix landed on the branch.