350495 - Crashes [@ nsFormFillController::SetPopupOpen]

Status: RESOLVED FIXED

(Toolkit :: Autocomplete, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

According to TB there are quite a few crashes @ http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/components/satchel/src/nsFormFillController.cpp&mark=253&rev=MOZILLA_1_8_BRANCH#253
If the document is being destroyed, docshell may be null.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: Adding null checks

This should be ok.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 235782 [details] [diff] [review]
Adding null checks

ugh, bugzilla doesn't like product/component changes

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

This should go to 1.8.1 too.

Comment 4

[Michael Wu [:mwu]]

Comment on attachment 235782 [details] [diff] [review]
Adding null checks

So apparently we can have this function called as the docshell is getting destroyed. Smaug thinks it may be caused by a timer. At any rate, I wonder if the presentation shell can be null when the docshell isn't, and if we really want to spit out another warning on the console if docshell ends up null.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

nsDocShell::GetPresShell may return null presshell.
(It is after all *Get*PresShell)

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 235782 [details] [diff] [review]
Adding null checks

r=jst

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 235782 [details] [diff] [review]
Adding null checks

Checked in to trunk.
Since the same crash may happen un 1.8.1. (but not in 1.8.0) asking for approval.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 235782 [details] [diff] [review]
Adding null checks

a=beltzner on behalf of 181drivers