Closed
Bug 350565
Opened 19 years ago
Closed 19 years ago
crash when using at-poke log text-caret-moved event [@nsHyperTextAccessible::GetRelativeOffset]
Categories
(Firefox :: Disability Access, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: evan.yan, Assigned: aaronlev)
References
Details
(Keywords: crash)
Crash Data
Attachments
(2 files)
|
15.23 KB,
text/plain
|
Details | |
|
1002 bytes,
patch
|
evan.yan
:
review+
|
Details | Diff | Splinter Review |
reproduce steps:
1. start firefox with accessibility enabled, locate to a webpage with textfield, say www.mozilla.org/projects/minefield;
2. start at-poke log event, check the checkbox for text-caret-moved event;
3. click on a textfield to focus;
then firefox crash. it can be always reproduced.
startFrame was null in nsHyperTextAccessible::GetTextHelper()
|
Assignee | |
Comment 3•19 years ago
|
||
Assignee: nobody → aaronleventhal
Status: NEW → ASSIGNED
Attachment #236261 -
Flags: review?(Evan.Yan)
Comment on attachment 236261 [details] [diff] [review]
Null check and return early
the patch does work for me.
but I'm curious about the condition that startFrame would be null, Aaron, could you please explain it for me?
|
|
Assignee | |
Comment 5•19 years ago
|
||
Evan, it is null because startOffset has been incremented past the end of the string.
FWIW I plan to change this code anyway for bug 349909.
Comment on attachment 236261 [details] [diff] [review]
Null check and return early
r=me
Attachment #236261 -
Flags: review?(Evan.Yan) → review+
|
|
Assignee | |
Updated•19 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
|
||
Updated•14 years ago
|
Crash Signature: [@nsHyperTextAccessible::GetRelativeOffset]
You need to log in
before you can comment on or make changes to this bug.
Description
•