350588 - Exception: "Node was not found" in toolbar.xml

Status: RESOLVED WORKSFORME

(Toolkit :: Toolbars and Toolbar Customization, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This happens with Thunderbird version 2 alpha 1 (20060828) when trying to customize the toolbar of the main window.

Steps:
1. Opened customize dialog
2. Double clicked checkbox for small icons
3. Closed dialog by pressing Esc

Between the double click you can see that the toolbar changes its visibility from visible to hidden and back very fast. But the exception is shown after closing the dialog.

This happens only onces within a session. To see it again you have to restart Thunderbird.

Error: uncaught exception: [Exception... "Node was not found"  code: "8" nsresult: "0x80530008 (NS_ERROR_DOM_NOT_FOUND_ERR)"  location: "chrome://global/content/bindings/toolbar.xml Line: 259"]

Querying lxr shows me following possible line:

this.insertBefore(insertItem, this.firstPermanentChild);

Ben, could this be related to one of your patches on bug 274712?

Comment 1

[Phil Ringnalda (:philor)]

Henrik, do you have your menu toolbar (the File-Edit-View-Etc. one) customized, with a button placed before the File menu? 

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Phil: I took this because I plan on working on improving customize toolbar code in general, but if you want to steal this from me now as part of your work on un-forking, go right ahead :)

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #1)
> Henrik, do you have your menu toolbar (the File-Edit-View-Etc. one) customized,
> with a button placed before the File menu? 

As an answer to you both, no I don't have customized my main menu in any way. And yes it can still be seen with version 2 beta 1 (20061104).

Comment 4

[Phil Ringnalda (:philor)]

It looks (near as I can tell squinting through the textbox.xml exceptions from bug 359773) like I wallpapered this with bug 288079, so whoever winds up with it will need to revert that to see that they've taught insertItem to look beyond the wrapper to the real firstPermanentChild within.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

WFM with Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.5pre) Gecko/20070627 Thunderbird/2.0.0.5pre Mnenhy/0.7.5.0 ID:2007062709 and at least with Thunderbird 2.0 on Windows.