350590 - Left Click on Back and Forward brings up dropdown

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Joseph]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060829 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060829 BonEcho/2.0b2

The clickable overshoot area around the back and forward buttons when using Small Icons has problems.  If you left click far enough to upper left, you end up with the dropdown instead of the action you intended. I often overshoot the icons slightly and end up with the dropdown instead of going back or forward. This happens under a new profile and safe mode.

UI Tweaker's option to hide the dropdowns makes this more noticeable and moves the problem area below the buttons.  I have been seeing the problem for a good while, but didn't realize what was going on until recently.

Reproducible: Always

Steps to Reproduce:
1.Move mouse to upper left active area on forward or back button.
2.Click in just the right area
3.

Actual Results:  
Dropdown is displayed

Expected Results:  
Go back or forward

Comment 1

[Joseph]

Attachment: screenshots showing the problem

These images are from a few days ago showing also bug #350183 (back/forward not aligned), but it is unrelated.  The same happens under today's build.

This happens with both large icons and small, but I find it easier to reproduce with small toolbar icons.

Comment 2

[Peter Kasting]

Setting target milestone and status whiteboard to improve chance of queries catching this, but it may not be a blocker.

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Reed thinks there's a dupe, but yeah, we should fix this.

Comment 4

[Asaf Romano (gone)]

Attachment: patch

Comment 5

[Asaf Romano (gone)]

Attachment: patch

gains few more pixels

Comment 6

[Mike Connor [:mconnor]]

Comment on attachment 236100 [details] [diff] [review]
patch

r+a=me on this branch theme bug

Comment 7

[Reed Loden [:reed]]

Uh, this is a DUPE of bug 348319. Please check to see which patch is better (or take both or something).

Comment 8

[Reed Loden [:reed]]

(In reply to comment #7)
> Uh, this is a DUPE of bug 348319. Please check to see which patch is better (or
> take both or something).

Ignore me. I was looking at the wrong screenshot. :(

Comment 9

[Asaf Romano (gone)]

Checking in browser/themes/winstripe/browser/browser.xml;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.xml,v  <--  browser.xm
l
new revision: 1.4.8.5; previous revision: 1.4.8.4
done

Comment 10

[Peter Kasting]

Maybe this is fixed for the no-text case, but it still reproduces on my Linux box in Icons + Text mode with today's build.

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Yeah, following the steps in comment 0, I still see this with a 0901 Windows branch build, when using "Icons and Text".

Comment 12

[Asaf Romano (gone)]

Attachment: fix "min-width: 57px;" mode

Comment 13

[Mike Connor [:mconnor]]

Comment on attachment 236593 [details] [diff] [review]
fix "min-width: 57px;" mode

r+a=me on this theme change, though I'm thinking this approach might be the wrong one in the longer term

Comment 14

[Asaf Romano (gone)]

Checking in browser/themes/winstripe/browser/browser.xml;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.xml,v  <--  browser.xm
l
new revision: 1.4.8.7; previous revision: 1.4.8.6
done