350591 - missed 'afxdtctl.h' header error while building

Status: RESOLVED INVALID

(Core Graveyard :: Embedding: MFC Embed, defect)

Description

[Dmitry Dartz]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.0.3705; .NET CLR 1.1.4322; Alexa Toolbar)
Build Identifier: 1.8.0.6

It appears that some testing tools in Mozilla-1.8.0.6 rely on afxdtctl.h header which is part of MFC7 (shipped with VC7 or higher) and is not available in VC6.

As stated on http://developer.mozilla.org/en/docs/Windows_Build_Prerequisites
VC6 is the official building tool for Firefox 2 and Firefox 1.5.0.x and therefore either this statememnt should be updated or relationship with afxdtctl.h should be adjusted (removed) :)




Reproducible: Always

Steps to Reproduce:
1. have this .mozconfig
# sh
# Build configuration script
#
# See http://www.mozilla.org/build/unix.html for build instructions.
#

. $topsrcdir/browser/config/mozconfig

# Options for 'configure' (same as command-line options).
ac_add_options --enable-debug
ac_add_options --enable-logging
ac_add_options --disable-strip
ac_add_options --disable-optimize

#ac_add_options --enable-static 
#ac_add_options --disable-shared 

ac_add_options --enable-tests
ac_add_options --enable-crypto
ac_add_options --enable-mathml
ac_add_options --disable-mailnews
ac_add_options --disable-ldap
ac_add_options --disable-installer

2. call this bat file:
call VCVARS32.BAT

set CYGWINBASE=C:\cygwin



set MOZ_TOOLS=c:\moztools
set PATH=%MOZ_TOOLS%\bin;%CYGWINBASE%\bin;%PATH%

cd c:\cygwin\bin
bash --login -i


3.run 
make -f client.mk build

Actual Results:  
mozilla/embedding/tests/mfcembed/components/stdafx.h(57) : fatal error
C1083: Cannot open include file: 'afxdtctl.h': No such file or directory


Expected Results:  
no fatal errors expected

as a workaround (not recommended though), one can copy missed header from MFC7 and seems everything works since that.

I'd recommend to find a better workaround and compile that header optionally.

Comment 1

[Dmitry Dartz]

sorry, it seems my system was screwed up and file AFXDTCTL.H was missed somehow.