Closed
Bug 350595
Opened 18 years ago
Closed 18 years ago
Untranslatable string in Element Properties
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: zwnj, Assigned: smontagu)
References
(Blocks 1 open bug, )
Details
(Keywords: intl)
Attachments
(2 files)
14.93 KB,
image/png
|
Details | |
1.71 KB,
patch
|
asaf
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
"Text Language" property in Element Properties uses two-letter language indicator, which is not translatable. I'm going to attach the screen-shot.
Reporter | ||
Comment 1•18 years ago
|
||
Shows: "text language: EN (united states)" [CAPS are English, and smalls are Persian]
Assignee | ||
Comment 2•18 years ago
|
||
I think the actual bug here is that the lang attribute is case sensitive. In an English build the language is shown as "English" for lang="en" and "EN" for lang="EN".
Keywords: l12y
Assignee | ||
Comment 3•18 years ago
|
||
For some reason the region code has always been case insensitive and the language code not (or maybe language code was assumed to be always lower case and region code always upper case, so it was lowercased to match the properties file). See RFC 3066 section 2.1: All tags are to be treated as case insensitive; there exist conventions for capitalization of some of them, but these should not be taken to carry meaning. For instance, [ISO 3166] recommends that country codes are capitalized (MN Mongolia), while [ISO 639] recommends that language codes are written in lower case (mn Mongolian).
Attachment #235927 -
Flags: superreview?(neil)
Attachment #235927 -
Flags: review?(bugs.mano)
Comment 4•18 years ago
|
||
Comment on attachment 235927 [details] [diff] [review] Make the language part of the lang attribute case-insensitive Is this likely to be a problem for internal consumers e.g. would EN-gb.dic confuse the spellchecker code? Note: metadata.js is due to move on trunk, I can't remember when though.
Attachment #235927 -
Flags: superreview?(neil) → superreview+
Assignee | ||
Updated•18 years ago
|
Assignee: nobody → smontagu
Assignee | ||
Comment 5•18 years ago
|
||
(In reply to comment #4) > (From update of attachment 235927 [details] [diff] [review] [edit]) > Is this likely to be a problem for internal consumers e.g. would EN-gb.dic > confuse the spellchecker code? Renaming my existing en-US.dic to EN-us.dic doesn't seem to bother the spellchecker. I did notice that hreflang="EN" confuses the links toolbar, if anyone cares.
Comment 6•18 years ago
|
||
Comment on attachment 235927 [details] [diff] [review] Make the language part of the lang attribute case-insensitive r=mano
Attachment #235927 -
Flags: review?(bugs.mano) → review+
Assignee | ||
Comment 7•18 years ago
|
||
Checked in
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•