350651 - Favicons on trunk cause writing into Console log

Status: RESOLVED FIXED

(Camino Graveyard :: Location Bar & Autocomplete, defect)

Description

[Chris Lawson (gone)]

Using a trunk nightly:

1) Open Console.log and filter on "NSImage".
2) Go to any site with a favicon.
3) Wonder why you just got the following line (or similar) in your console log:

2006-08-29 22:32:39.718 Camino[6879] NSImageCell's object value must be an NSImage.

4) Go to another site with a favicon.
5) Watch the line duplicate itself.

Browsing on Bugzilla does not result in duplicate log lines; it seems the logging only happens the first time an icon is loaded. However, if you go to a different site and go back to the first site manually (i.e., typing it in rather than using the Back button), you get the message again, so it's not a simple issue of only occurring when the icon's not in the cache.

Not a big deal, but something we should probably fix when we can. This does not appear to happen at all on branch builds or in the 1.0.x releases.

Comment 1

[Chris Lawson (gone)]

http://landfill.mozilla.org/mxr-test/mozilla/source/camino/src/browser/AutoCompleteTextField.mm#290

is the only reference I can find in our codebase to an NSImageCell.

cl

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also bug 346111 comment 2 and 3 (though that may be quite different).

Comment 3

[Stuart Morgan]

Are you still seeing this?  I can't reproduce with the 8/31 trunk nightly (10.4.7, Intel)

Comment 4

[Chris Lawson (gone)]

Still seeing this on PPC with 8/31 trunk nightly. Going to my "bugs filed today" query (from autocomplete) triggered the console message, as it had in the past.

cl

Comment 5

[Chris Lawson (gone)]

Fixed by the checkin for bug 346111. I no longer see this in trunk nightlies ever since that landed.

Comment 6

[Stuart Morgan]

*** Bug 354918 has been marked as a duplicate of this bug. ***