350661 - Add Recent Folder Target to Move and Copy Menus

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

Now that David's done all this great work to build a Recent Folders data source, we should leverage it, adding it as a top level menu item in the Copy and Move menus before we list the accounts. clicking Recent would then bring up the menupopup listing recent folders which are valid move/copy targets.

Comment 1

[Scott MacGregor]

Attachment: functional work in progress

Comment 2

[Scott MacGregor]

Attachment: screen shot

Comment 3

[David :Bienvenu]

Comment on attachment 236299 [details]
screen shot

so nice!

Comment 4

[Scott MacGregor]

Attachment: the fix

Ok, here's an updated patch. 

Please see Bug 350962 where we're talking about trying to consolidate the duplicated XUL for the copy and move menus into an XBL widget.

Comment 5

[Scott MacGregor]

cc'ing Karsten. Karsten, this is a pretty simple change you might be interested in for seamonkey. It takes advantage of the recent folder data source work David did.

Comment 6

[Scott MacGregor]

re-opening. We should add this for the file button too!

Comment 7

[Scott MacGregor]

Attachment: add recent folders to the file button

add the same template building code to the file toolbar button.

Comment 8

[Mike Cowperthwaite]

Is there any chance that these sweeping changes could *not* be just automatically plunked down on the branch?  What happened to the idea of "letting it bake"?  That concept applies to UI just as much as, perhaps more than, the backend tweaks.

Comment 9

[Peter Reynolds]

Move To, Recent *copies* instead of *moving* (as of 20060904 nightly).

Comment 10

[Thomas Stache]

(In reply to comment #9)
> Move To, Recent *copies* instead of *moving* (as of 20060904 nightly).
> 

I can confirm that. The original message is not removed from the source folder when using the "Recent" menu of the "File" toolbar button. On IMAP that is.

Comment 11

[Mike Cowperthwaite]

With 2a1-0901, Win2K, I just tried Moving Again from a POP Inbox to a Local Folder, and it moved.

Comment 12

[Scott MacGregor]

Attachment: make Recent Folders for the file toolbarbutton use Move instead of copy

David's on vacation so I'll ask seth for a small code review.

Comment 13

[(not reading, please use [e-mail] instead)]

Comment on attachment 236864 [details] [diff] [review]
make Recent Folders for the file toolbarbutton use Move instead of copy

sr=sspitzer, acting mailnews sr while david is out.

Comment 14

[Scott MacGregor]

Attachment: fix 2 more move menus which were copying instead of moving

Comment 15

[Scott MacGregor]

I'm starting to think it might be more interesting to remove the recent menupopup and put the recent folders themselves directly in the move / copy menu.

i.e.

Move To --> 
        recent folder 1
        recent folder 2
        etc....etc..
        ------------
        Work Account -> Inbox
                        Drafts
        Work Account 2 -> Inbox

Comment 16

[Mike Cowperthwaite]

(In reply to comment #15)
> I'm starting to think it might be more interesting to remove the recent
> menupopup and put the recent folders themselves directly in the move / copy
> menu.

xref bug 350962 comment 3.

Comment 17

[Jay Smith]

Sorry for the annoyance, but can anybody tell me:

a) the quantity of MRU entries permitted? 

b) whether the quantity is configurable?

From a practical standpoint, anything below 20 significantly reduces the utility for me.

The reason for the question: I am STILL on Mozilla 1.7.3 on RedHat 8.  This feature would significantly add to the reasons to move up.  However, moving up also means replacing RH8 which also means replacing the server hardware as well as upgrading or migrating several major software packages, databases, etc., etc. It is a slippery slope, but getting MRU (and a Subscribe more functional than on 1.7.3) would really add to the positive column.

Jay

Comment 18

[Carsten Book [:Tomcat]]

verified fixed 1.8.1.3 using Mozilla/5.0 (Windows; U; Windows NT 5.2; en-US; rv:1.8.1.3) Gecko/20070326 Thunderbird/2.0.0.0 Mnenhy/0.7.5.0 ID:2007032620 the Recent Folder Target for move and copy menus looks good and is working well

Comment 19

[Serge Gautherie (:sgautherie)]

Attachment: (Ev1) <mailWindowOverlay.xul> remove leftover menupopup

Issue:
[Mozilla Thunderbird, version 3.0a1pre (2008021003)] (nightly) (W2Ksp4)
shows an empty 'menupopup' in the upper left corner of the toolbar File button :-(

Fix:
*Split a few "long" lines, to sync with bug 416669.
*Remove leftover |<menupopup/>|, missed in attachment 236448 [details] [diff] [review].

Comment 20

[Phil Ringnalda (:philor)]

Comment on attachment 302411 [details] [diff] [review]
(Ev1) <mailWindowOverlay.xul> remove leftover menupopup

No line break changes that only serve to bitrot the patch in bug 413781, please. If you want, you can file a new bug with a patch that just removes the stray <menupopup/>, and make it dependent on bug 413781, so we won't accidently leave it in if that falls through.

Comment 21

[Serge Gautherie (:sgautherie)]

(In reply to comment #20)
> (From update of attachment 302411 [details] [diff] [review])
> No line break changes that only serve to bitrot the patch in bug 413781,
> please. If you want, you can file a new bug with a patch that just removes the
> stray <menupopup/>, and make it dependent on bug 413781, so we won't accidently
> leave it in if that falls through.

Allow me to insist a little: see bug 413781 comment 12.
Joey, or even I, will handle the bitrot.
Isn't it better to fix the "underlying" UI issues now as I'm working on them, rather than delay everything waiting for Joey to get back to it (and make a mixed UI+backend patch) ?
I think sync'ing SM and TB and fixing them at the same time is much better, isn't it ?

Comment 22

[Serge Gautherie (:sgautherie)]

(In reply to comment #20)
> you can file a new bug with a patch that just removes the stray <menupopup/>,

Bug 454859 fixed this part :-|