350687 - need new "inner arrow" images for scroll right / scroll left arrow buttons in the tab strip

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[(not reading, please use [e-mail] instead)]

need new images for alltabs button and scrollbuttons to match new images for tab strip?

the new images for the tabs have a white edge, but the existing images for the all tabs button and the scroll buttons do not, and it seems like they should.

let me attach a screen shot.

Comment 1

[(not reading, please use [e-mail] instead)]

Attachment: screen shot, "white edge" of tab highlighted by red box

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

--> me for decision

Comment 3

[(not reading, please use [e-mail] instead)]

beltzner and I just chatted, and there are several issues with these three UI elements that we think can be fixed with new images.

I'll let mike weigh in here.

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

*** Bug 348942 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

*** Bug 348943 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Jay/RC are to deliver new graphics here:

As Seth states in this bug, the icons need to match their respective tabstrips, and be semitransparent to pick up the native tabstrip colouring.

From bug 348942, the states of the tab buttons should be as follows:

* "All Tabs" button: always appears like background tab, appears like active tab on hover 

* Tab scrollbuttons: appear like background tabs when there is nowhere left to scroll, appear like forground tabs when user can click to scroll, icon highlights on hover, highlight darkens on click

From bug 348943, the All-Tabs button is OK as a caret/drop down, but the scroll buttons arrows should be black, and thinner, more like the drop-down caret to
carry the association between these controls (as pkasting suggests)

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

*** Bug 349955 has been marked as a duplicate of this bug. ***

Comment 8

[Peter Kasting]

(In reply to comment #6)
> * "All Tabs" button: always appears like background tab, appears like active
> tab on hover 
> 
> * Tab scrollbuttons: appear like background tabs when there is nowhere left to
> scroll, appear like forground tabs when user can click to scroll, icon
> highlights on hover, highlight darkens on click

Does the All Tabs icon highlight on hover/darken on click like the scrollbuttons' icons?

Are you sure it's not weird to use "background vs. foreground" to indicate that the scrollbuttons are clickable, but always make the All Tabs image "background"?  I would think it should always be "foreground" for consistency...

Comment 9

[(not reading, please use [e-mail] instead)]

additionally, the images need to be semi-transparent (See bug #350690) so that they will play nice with the native OS theme and high contrast mode.

Comment 10

[Dão Gottwald [:dao]]

(In reply to comment #6)
> Jay/RC are to deliver new graphics here:

Okay. I guess it's not that difficult, since you can take the tabs' images, basically. Anyway, if you need me, let me know.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Note that bug 351755 requires these images to be semi-transparent.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Ah, nevermind me, seth's already commented and with the right bug number!

Comment 13

[Jay Goldman]

Attachment: Pinstripe: Tab Arrows

Comment 14

[Jay Goldman]

Attachment: Winstripe: Tab Arrows

Comment 15

[Mike Connor [:mconnor]]

Comment on attachment 237691 [details]
Pinstripe: Tab Arrows

These lack the multiple images that were implemented later (disabled/hover/enabled/active)

Comment 16

[Jay Goldman]

Attachment: Pinstripe: full tab arrows with all states

Now includes On, Hover, Disabled, Active states.

Comment 17

[Jay Goldman]

Attachment: Winstripe: full tab arrows with all states

Now includes On, Hover, Disabled, and Active states

Comment 18

[Peter Kasting]

*** Bug 350372 has been marked as a duplicate of this bug. ***

Comment 19

[(not reading, please use [e-mail] instead)]

jay, thanks for these new images.  note, tab-arrow-end.png for both winstripe and pinstripe had an off by 1px issue.  (the three right most "arrows" need to be shifted to the left by 1 px in order for things to work.)

I've fixed that locally, tested your images, and will go check in (r/a=mconnor)

Comment 20

[(not reading, please use [e-mail] instead)]

I've landed the new images from jay.  

beltzner's comment #6 covers several issues, as does the bugs original summary.

should we morph this but to just cover the new images from jay and log new bugs on any outstanding issues, or should we keep this one open?

Comment 21

[(not reading, please use [e-mail] instead)]

Comment on attachment 237736 [details]
Pinstripe: full tab arrows with all states

r=sspitzer (and these got landed with a=mconnor).  note, one of the images was modified locally before I landed it.

Comment 22

[(not reading, please use [e-mail] instead)]

Comment on attachment 237737 [details]
Winstripe: full tab arrows with all states

r=sspitzer (and these got landed with a=mconnor).  note, one of the images was modified locally before I landed it.

Comment 23

[Mike Connor [:mconnor]]

Comment on attachment 237736 [details]
Pinstripe: full tab arrows with all states

r+a=me for both sets (just for formality's sake)

Comment 24

[(not reading, please use [e-mail] instead)]

> should we morph this but to just cover the new images from jay and log new bugs
> on any outstanding issues, or should we keep this one open?

morphed to cover what actually got fixed here, I'll log new bugs on the outstanding issues.

Comment 25

[(not reading, please use [e-mail] instead)]

> morphed to cover what actually got fixed here, I'll log new bugs on the
> outstanding issues.

before I morhped it, the old summary was:  "need new images for alltabs button and scrollbuttons to match new images for tab strip (including transparency)"

I can't think of any outstanding issues, so I'm not going to log any bugs.