350704 - Some "let" expressions in "for" initial-expression still become "let" statements above the "for"

Status: VERIFIED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Jesse Ruderman]

> function() { try{} catch(y) { for(z(let(y=3)4); ; ) ; } }
function () { try { } catch (y) { let y = 3; for (z(4);;) { } } }

Attempting to recompile the result gives "redeclaration of variable y".

This is similar to bug 349605 and bug 348904.

Comment 1

[Brendan Eich [:brendan]]

Due to incomplete fix for bug 349605.  Patch next.

/be

Comment 2

[Brendan Eich [:brendan]]

Attachment: fix

Comment 3

[Brendan Eich [:brendan]]

Fixed on trunk.

Checking in jsemit.c;
/cvsroot/mozilla/js/src/jsemit.c,v  <--  jsemit.c
new revision: 3.191; previous revision: 3.190
done

/be

Comment 4

[Brendan Eich [:brendan]]

Comment on attachment 236114 [details] [diff] [review]
fix

Another safe decompiler fix, really yet another forgotten case from bug 349605.

/be

Comment 5

[Bob Clary [:bc] (inactive)]

Checking in regress-350704.js;
/cvsroot/mozilla/js/tests/js1_7/block/regress-350704.js,v  <--  regress-350704.js
initial revision: 1.1

Comment 6

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20060831 windows/mac*/linux

I screwed up the test from this morning:
Checking in regress-350704.js;
/cvsroot/mozilla/js/tests/js1_7/block/regress-350704.js,v  <--  regress-350704.js
new revision: 1.2; previous revision: 1.1
done

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 236114 [details] [diff] [review]
fix

a=beltzner on behalf of 181drivers

Comment 8

[Brendan Eich [:brendan]]

Fixed on the 1.8 branch.

/be

Comment 9

[Bob Clary [:bc] (inactive)]

verified fixed 1.9 20060901 windows/mac*/linux