Closed Bug 350737 Opened 18 years ago Closed 18 years ago

Increase padding around search engines in search engine manager dialog

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Version:
2.0 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 2

People

(Reporter: Gavin, Assigned: Gavin)

Details

(Keywords: fixed1.8.1)

Attachments

(2 files)

increase padding
1.83 KB, patch
mconnor
: review+
beltzner
: approval1.8.1+
Details | Diff | Splinter Review
after and before
20.84 KB, image/png
Details 
<mconnor> gavin_: the line height should be 18px at least
<mconnor> so 1px on top and bottom around the icon
<mconnor> and 2px left/right of the icon
Flags: blocking-firefox2?
Target Milestone: --- → Firefox 2
Attached patch increase padding — — Splinter Review 
I'll post a comparison screenshot. I'll try to find someone to test on the mac.
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #236101 - Flags: review?(mconnor)
Whiteboard: [patch-r?]
Attachment #236102 - Attachment description: before and after → after and before
Comment on attachment 236101 [details] [diff] [review]
increase padding

r=me, looks good
Attachment #236101 - Flags: review?(mconnor) → review+
mozilla/browser/themes/winstripe/browser/engineManager.css 	1.2
mozilla/browser/themes/pinstripe/browser/engineManager.css 	1.2
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Whiteboard: [patch-r?]
Comment on attachment 236101 [details] [diff] [review]
increase padding

Simple patch to tweak padding in the engine manager tree, no regression risk.
Attachment #236101 - Flags: approval1.8.1?
Flags: blocking-firefox2?
Whiteboard: [needs approval]
Comment on attachment 236101 [details] [diff] [review]
increase padding

a=beltzner on behalf of 181drivers
Attachment #236101 - Flags: approval1.8.1? → approval1.8.1+
Also unable to bookmark
Whiteboard: [needs approval] → [checkin needed (1.8 branch)]
mozilla/browser/themes/winstripe/browser/engineManager.css 	1.1.2.2
mozilla/browser/themes/pinstripe/browser/engineManager.css 	1.1.2.2
Keywords: fixed1.8.1
Whiteboard: [checkin needed (1.8 branch)]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: