350738 - Search service engine ordering code should use localeCompare

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

... so that the sorting is correct for engines with non-ASCII names.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 236096 [details] [diff] [review]
patch

good catch.  Is this actually causing weirdness otherwise?

Comment 3

[Axel Hecht [:Pike]]

I think that the rakuten plugin for japanese would be sorted oddly, if Japanese wouldn't actually specify plugin ordering completely.
I bet most intl brandnames are ascii in the internet business as they want their brand to directly map to domain names, too.
Looking at http://people.mozilla.com/~axel/release/search-engines.html (future note, that link is not permanent), all our ShortNames apart from Rakuten at least start with ascii. Japanese Yahoo has several plugins differing only in japanese script, but again, japanese is fully ordered.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.80

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 236096 [details] [diff] [review]
patch

a=mconnor on behalf of drivers for 1.8 branch checkin

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.1.2.64