350739 - Drop down buttons are too wide

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Adam Guthrie]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a1) Gecko/20060830 Minefield/3.0a1

After the patch for bug 348614, the width of drop down buttons, e.g. the all tabs button and back/forward buttons increased. 

Personally, I don't like this change. Was the change in appearance intentional? I thought it was more of a consolidation than an appearance change.

Comment 1

[Neil Deakin]

No, no changes to the appearance were intended.

Comment 2

[Asaf Romano (gone)]

Neil, can you take this? This is also breaking the alltabs-button on trunk.

Comment 3

[Asaf Romano (gone)]

Also, I see this in Pinstripe too.

Comment 4

[Dão Gottwald [:dao]]

If the change was intended, the alltabs-button's background image could be widened.

Comment 5

[Neil Deakin]

It wasn't intended. I'm currently testing a fix.

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> It wasn't intended.

Sorry, I misread comment 1.

Comment 7

[Asaf Romano (gone)]

*** Bug 353879 has been marked as a duplicate of this bug. ***

Comment 8

[(not reading, please use [e-mail] instead)]

additionally, you can see the effect of this bug on the hover state of the back / fwd buttons (when they are enabled)

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: screen shot of hover over back button

Comment 10

[Neil Deakin]

Attachment: Fix width of dropmarkers

The Mac toolkit seemed to be using different images for the dropmarkers than all other themes (even Mac Seamonkey). I changed the images back to this different set, although maybe we should try for consistency?

Comment 11

[[e-mail]]

Comment on attachment 240154 [details] [diff] [review]
Fix width of dropmarkers

Does the auto width need to be important? (I'd hope not but didn't try it)

Comment 12

[Asaf Romano (gone)]

Comment on attachment 240154 [details] [diff] [review]
Fix width of dropmarkers

r=mano

Comment 13

[Neil Deakin]

Checked in