350747 - change nsIContent so it can be used by extensions

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[aaronr]

nsIContent.h currently has most of its methods inside ifdef MOZILLA_INTERNAL_API which will not be available to extensions once --enable-libxul is turned on by default and extensions no longer allowed to build with MOZILLA_INTERNAL_API.  Talking to bz and bsmedberg, they don't see that this restriction in nsIContent.h as required and that extensions should be able to use nsIContent.  For example, XForms really needs access to nsIContent->IntrinsicState and nsIContent->GetBaseURI.

So this bug is to remove the ifdef MOZILLA_INTERNAL_API's inside nsIContent.h and nsINode.h.

Comment 1

[Alex Vincent [:WeirdAl]]

Do you mean C++-based extensions only, or all XPCOM-based extensions?  (That is, would nsIContent be exposed to JavaScript-based components and to chrome?)

Comment 2

[aaronr]

Attachment: patch

Comment 3

[aaronr]

c++ extensions

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 236111 [details] [diff] [review]
patch

Looks reasonable.

Comment 5

[aaronr]

I checked this into trunk and had to back it out.  Broke non MOZILLA_INTERNAL_API compiled testcases (in mozilla/extensions/xmlextras/tests) on Linux due to nsIDocument.h.  I'll make a new patch that changes nsIDocument.h, but I have to wait until after Labor Day to test it on a Linux machine with tests enabled.

Comment 6

[aaronr]

Attachment: patch 2

updated previous patch to include change to nsIDocument.h.  As far as I can tell, this should prevent any similar build breaks.  No one else seems to override nsINode w/o this one-parameter constructor.

Comment 7

[Benjamin Smedberg]

Why don't you leave both constructors ifdefed, since there's no possible way to use them from frozen-linkage code?

Comment 8

[aaronr]

Attachment: patch w/o constructor change

patch using bsmedberg's most excellent suggestion

Comment 9

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 237238 [details] [diff] [review]
patch w/o constructor change

>Index: content/base/public/nsIContent.h
>+#endif
...
>-#endif // MOZILLA_INTERNAL_API

You lost the comment.  Please put it back.

r+sr=bzbarsky with the comment there.

Comment 10

[aaronr]

checked into the trunk yesterday afternoon.