Closed
Bug 350748
Opened 18 years ago
Closed 18 years ago
change nsIParserService to use nsStringGlue
Categories
(Core :: DOM: HTML Parser, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: aaronr, Assigned: aaronr)
References
Details
Attachments
(1 file)
|
4.12 KB,
patch
|
mrbkap
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
when --enable-libxul is turned on in the default build and c++ extensions are no longer allowed to build with MOZILLA_INTERNAL_API, these extensions will no longer be able to use the services provided by nsIParserService due to string issues. I have put together a patch will will remove nsString.h from nsIParserService and replace it with nsStringGlue.h. I also had to change the signature of CheckQName to now take a nsAString instead of a fragmented string and slightly change how it uses Begin/EndReading. No real functional changes, though. bsmedberg said that since strings are no longer fragmented, then this is not an issue.
Attachment #236115 -
Flags: review?(mrbkap)
|
||
Updated•18 years ago
|
Attachment #236115 -
Flags: review?(mrbkap) → review+
Attachment #236115 -
Flags: superreview?(jst)
|
||
Comment 2•18 years ago
|
||
Comment on attachment 236115 [details] [diff] [review] patch sr=jst
Attachment #236115 -
Flags: superreview?(jst) → superreview+
checked into trunk
Status: NEW → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•