Expand/collapse widget still appears in left pane of Bookmarks Manager for folders with no subfolders

RESOLVED WONTFIX

Status

()

Firefox
Bookmarks & History
--
minor
RESOLVED WONTFIX
12 years ago
9 years ago

People

(Reporter: Patrick Lee, Unassigned)

Tracking

2.0 Branch
x86
Windows XP
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

12 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060830 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060830 BonEcho/2.0b2

In the left pane of the Bookmarks Manager, the expand/collapse widget (plus/minus icon) appears whenever a folder is non-empty.  This includes the case when the only contents of a folder are bookmarks with no subfolders.  This appears to mimic the behavior seen in the right pane where empty folders have no expand/collapse widget available because there is nothing inside of them to see.

However, in the left pane, the expand/collapse widget should only appear next to folders that actually have subfolders.  Presently, clicking on the plus icon next to a folder without subfolders just toggles the icon and doesn't do anything useful.  Removing the plus/minus icon where it is not needed would also have the benefit of allowing users to see at a glance which folders actually do have subfolders rather than clicking on each one to see if it expands or not.

Reproducible: Always

Steps to Reproduce:
1. Create a bookmarks folder and put one bookmark in it.
2. Launch Bookmarks Manager.
3. Click on plus icon next to folder in left pane.

Actual Results:  
Plus icon changes to minus icon and folder opens slightly.

Expected Results:  
Plus icon should not even appear next to folders without subfolders in left pane.

Comment 1

12 years ago
Same issue in Firefox 1.5.0.6.  

In Windows Explorer, the "expand/collapse" widget is only shown for folders with sub folders.

In Minefield (places), the "expand/collapse" widget is shown for folders that don't have subfolders.  Clicking it shows the contents of the folder.
Status: UNCONFIRMED → NEW
Ever confirmed: true
(Reporter)

Comment 2

12 years ago
(In reply to comment #1)
> In Minefield (places), the "expand/collapse" widget is shown for folders that
> don't have subfolders.  Clicking it shows the contents of the folder.

Yes, but isn't that just in the right pane?  I'm talking about useless expand/collapse widgets in the left pane (folder view) where the only reason for them to be present is to view/hide subfolders.  I agree with you that any non-empty folder in the right pane should have the widget.

I filed this bug based on what I observed in the latest Bon Echo build.  Does Minefield preserve the two-pane Bookmarks Manager or is the UI significantly different?

Comment 3

12 years ago
I think this may be the same as bug 76525.  Or that patch may fix this problem as well.  

Also there doesn't seem to be a problem on the trunk.  The places window shows folders and bookmarks in the left and right pane.  The one place where only folders are shown is the add bookmark dialog.  And that dialog does not have this problem.  
Version: unspecified → 2.0 Branch
(Reporter)

Comment 4

12 years ago
(In reply to comment #3)
> I think this may be the same as bug 76525.  Or that patch may fix this problem
> as well.  

Hmmm, doesn't look like that bug was ever actually resolved.  Probably doesn't bode well for this one so late in the 2.0 cycle.  At least now I know what to call those things: twisties!

> Also there doesn't seem to be a problem on the trunk.  The places window shows
> folders and bookmarks in the left and right pane.  The one place where only
> folders are shown is the add bookmark dialog.  And that dialog does not have
> this problem.  

Interesting.  I'll have to check that out.  Well if this bug is not present on the trunk, then we either fix it on the 2.0 branch or mark it WONTFIX.  Whether or not this can be fixed easily without affecting something else is beyond my knowledge, so I'll defer to the experts.  If nobody else has filed a bug on this issue in more than five years, then I suppose it's not all that important to anybody but me.  Any thoughts?
not going to take further fixes on 2.x, feel free to reopen if you can reproduce on 3.x or current trunk
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.