350762 - too much spacing before tab's icon and after tab's close button

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[aja+bugzilla]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060830 Minefield/3.0a1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060830 Minefield/3.0a1

bug 348698 patch 235967 inadvertently added 5px (?) right padding between close button and end of tab.

looks like perhaps it did the same for spacing between start of tab and the tab's favicon.

Reproducible: Always

Comment 1

[:Gavin Sharp [email: [e-mail]]]

I don't see any difference between the tab close buttons in a build with that patch and a build without. This might be due to another bug.

Comment 2

[aja+bugzilla]

Ignore initial description above.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060830 Minefield/3.0a1 ID:2006083011 [cairo]

Too much space between beginning of tab and the tab's icon.
Too much space between tab close button [X] and end of tab.
IMHO

Not caused by bug 348698 after all.

Comment 3

[Jesse Maloney (jtmal0723 [at] gmail for email)]

(In reply to comment #2)
> Ignore initial description above.
> 
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20060830
> Minefield/3.0a1 ID:2006083011 [cairo]
> 
> Too much space between beginning of tab and the tab's icon.
> Too much space between tab close button [X] and end of tab.
> IMHO
> 
> Not caused by bug 348698 after all.
> 

Is this being seen in the latest branch nightly? Your build identifier is saying you're seeing this in a trunk nightly.

Comment 4

[John Hanna]

Attachment: Tab icon padding example

Comment 5

[John Hanna]

Comment on attachment 236161 [details]
Tab icon padding example

Using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060830 BonEcho/2.0b2 ID:2006083003

Comment 6

[aja+bugzilla]

(In reply to comment #3)

> 
> Is this being seen in the latest branch nightly? Your build identifier is
> saying you're seeing this in a trunk nightly.
> 

Damn...wrong build listed twice...not my day.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060830 BonEcho/2.0b2 ID:2006083016

Comment 7

[Ria Klaassen (not reading all bugmail)]

Attachment: screenshot comparison

Comment 8

[Ria Klaassen (not reading all bugmail)]

This is a regression between 1.8.1b2_2006082922 and 1.8.1b2_2006083013 so I think bug 347482 might have caused this.

Comment 9

[Mike Connor [:mconnor]]

what we need to do is match top padding with start/end padding, just to balance that

Comment 10

[(not reading, please use [e-mail] instead)]

as pointed out by ria, this is because of a change I made.  

the tab edge images are now 2px wider (8 to 10 px), and I failed to notice this side effect.

should be simple to fix, I'll fix the css and the images and attach a patch.

Comment 11

[(not reading, please use [e-mail] instead)]

> what we need to do is match top padding with start/end padding, just to balance
> that

mconnor is also right, I need to twiddle the padding, too

Comment 12

[(not reading, please use [e-mail] instead)]

the fix was to revert the css to have the tab left / right image widths at 8px (instead of 10px) and to fix the images.

I've just landed the fix.

see bug #350139 for the patch.