350844 - Feeds preferences pane hangs and then crashes when selecting a web handler if the initially selected option was "Show me a preview" (in instant-apply mode)

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Asaf Romano (gone)]

In instant apply mode, we sometimes crash (after a short hang) when selecting a web handler from the list. It seems this only happens if "show me a preview" was the selected option when the pane was loaded.

Debugging this a bit shows this is happening due the weak preference observer on PREF_SELECTED_WEB, probably due to some bad xpconnect cycles between the preferences bindings to the weak observer

Comment 1

[Asaf Romano (gone)]

Attachment: patch

Also fix an issue where the listbox select event bubbles to the radiogroup and causes us to save the preferences yet another time.

Comment 2

[Adam Guthrie]

Is this the same crash as bug 348940? (It's hard to tell without a stack, but judging from the patch it seems like it could be.)

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 236216 [details] [diff] [review]
patch

r+a=me on this branch-only patch, thanks Mano

Comment 4

[Asaf Romano (gone)]

Mike, note I've already landed the trunk patch for bug 346009, so this goes there too.

Comment 5

[Asaf Romano (gone)]

1.8 branch:
mozilla/browser/components/preferences/feeds.js 1.1.2.3
mozilla/browser/components/preferences/feeds.xul 1.1.2.3

Comment 6

[Asaf Romano (gone)]

trunk:
mozilla/browser/components/preferences/feeds.js 1.3
mozilla/browser/components/preferences/feeds.xul 1.3