Closed Bug 350845 Opened 14 years ago Closed 10 years ago

Implement relevant parameter methods (enumerate, exists, set)

Categories

(Calendar :: Internal Components, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mattwillis, Assigned: Fallen)

Details

Attachments

(1 file)

spinoff from bug 322831:

"Please file another bug for implementing other relevant
parameter methods (enumerate, exists(?), set)."
Taking, I have a patch for this I will upload later. One thing I noticed during testing, it doesn't seem to be possible to use non-X parameters, they get lost on roundtrip. Is this wanted behavior? Example:

createEventFromIcalString("BEGIN:VEVENT\nX-FOO;BAR=BAZ:QUUX\nEND:VEVENT").icalString

->  X-FOO:QUUX

createEventFromIcalString("BEGIN:VEVENT\nX-FOO;X-BAR=BAZ:QUUX\nEND:VEVENT").icalString

->  X-FOO;X-BAR=BAZ:QUUX
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Flags: in-testsuite?
Attached patch Fix - v1 β€” β€” Splinter Review
The Promised patch, with tests
Attachment #397915 - Flags: review?(mschroeder)
Whiteboard: [needs review]
Attachment #397915 - Flags: review?(mschroeder) → review?(Mozilla)
Comment on attachment 397915 [details] [diff] [review]
Fix - v1

Patch looks good.

Test passes:
TEST-PASS | 
C:\mozilla-build\msys\home\Markus\comm-1.9.1\objdir-sb-release\mozilla\_tests\xpcshell\test_calendar\unit\test_bug350845.js
| test passed

r=markus
Attachment #397915 - Flags: review?(Mozilla) → review+
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/4f0d6958bf72>
and comm-1.9.1 <http://hg.mozilla.org/releases/comm-1.9.1/rev/03133384ab3e>

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Whiteboard: [needs review]
Target Milestone: 1.0 → 1.0b1
You need to log in before you can comment on or make changes to this bug.