Closed
Bug 350849
Opened 18 years ago
Closed 18 years ago
User agent/build id missing from about:
Categories
(Firefox :: General, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: zeniko, Assigned: zeniko)
Details
(Keywords: fixed1.8.1)
Attachments
(1 file)
|
2.24 KB,
patch
|
mconnor
:
review+
mconnor
:
approval1.8.1+
|
Details | Diff | Splinter Review |
This might well be a DUPE since the issue has existed for over a week now. Steps to reproduce: 1. Open about: Actual result: Error: uncaught exception: Permission denied to get property UnnamedClass.classes Expected result: Get an easily copyable version of the user agent (incl. build id).
Comment 1•18 years ago
|
||
CC'ing zach, since bug 345993 changed this code.
Comment 2•18 years ago
|
||
bug 349985?
| Assignee | ||
Comment 3•18 years ago
|
||
This is rather a regression from bug 346186 and should be fixed by either backing out that code or at least try-catching it as long as bug 349985 isn't fixed.
Keywords: regression
Comment 4•18 years ago
|
||
Yeah, this is 349985. I'm glad to see someone noticed this. *** This bug has been marked as a duplicate of 349985 *** *** This bug has been marked as a duplicate of 349985 ***
| Assignee | ||
Comment 5•18 years ago
|
||
No duplicate (unless you want to morph that other bug). I don't care what kind of privileges about: gets - as long as I get my user agent/build id displayed.
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
| Assignee | ||
Comment 6•18 years ago
|
||
Drivers: This low-risk patch adds a try-catch block so that the user agent in about: is displayed even when Components.classes isn't available.
Assignee: nobody → zeniko
Status: REOPENED → ASSIGNED
Attachment #236226 -
Flags: review?(dietrich)
Attachment #236226 -
Flags: approval1.8.1?
Comment 7•18 years ago
|
||
Comment on attachment 236226 [details] [diff] [review] graciously handle lacking privileges r+a=me, low risk patch to something we don't expose in the UI, and is fundamentally correct and safe
Attachment #236226 -
Flags: review?(dietrich)
Attachment #236226 -
Flags: review+
Attachment #236226 -
Flags: approval1.8.1?
Attachment #236226 -
Flags: approval1.8.1+
Comment 8•18 years ago
|
||
I'd also like to see a patch that removes the release notes link text entirely if it doesn't have the needed permission to display the link. :)
| Assignee | ||
Comment 9•18 years ago
|
||
(In reply to comment #8) > I'd also like to see a patch that removes the release notes link text entirely > if it doesn't have the needed permission to display the link. :) You've got better chances of getting that wish granted when filing a new bug toward that end. ;)
Whiteboard: [checkin needed][checkin needed (1.8 branch)]
Target Milestone: --- → Firefox 2
Comment 10•18 years ago
|
||
mozilla/toolkit/content/about.xhtml 1.20 mozilla/toolkit/content/about.xhtml 1.8.8.11
Status: ASSIGNED → RESOLVED
Closed: 18 years ago → 18 years ago
Keywords: fixed1.8.1
Resolution: --- → FIXED
Whiteboard: [checkin needed][checkin needed (1.8 branch)]
You need to log in
before you can comment on or make changes to this bug.
Description
•