Closed
Bug 350854
Opened 20 years ago
Closed 20 years ago
Back/Forward Text is vertically misaligned in 'Icon and Text' mode
Categories
(Firefox :: Toolbars and Customization, defect)
Tracking
()
RESOLVED
FIXED
Firefox 2
People
(Reporter: zeniko, Assigned: asaf)
References
Details
(Keywords: fixed1.8.1, regression, Whiteboard: [Fx2 theme change])
Attachments
(3 files, 1 obsolete file)
|
16.42 KB,
image/png
|
Details | |
|
3.02 KB,
image/gif
|
Details | |
|
1.12 KB,
patch
|
Details | Diff | Splinter Review |
Steps to reproduce:
1. Customize the toolbar to display big icons with text
Actual result:
The text is further apart from the icons than it is for all other toolbar buttons.
Expected result:
Those two buttons shouldn't really stand out.
| Reporter | ||
Updated•20 years ago
|
Flags: blocking-firefox2?
Whiteboard: [Fx2 theme change]
Target Milestone: --- → Firefox 2
| Reporter | ||
Comment 1•20 years ago
|
||
Comment 2•20 years ago
|
||
"Back/Forward Text is vertically misaligned in 'Icon and Text' mode" sounds like a better description. Beat me at filing a bug for it.
| Assignee | ||
Comment 3•20 years ago
|
||
Simon, have you tested this after the checkin of bug 350590?
| Reporter | ||
Comment 4•20 years ago
|
||
(In reply to comment #3)
Tested with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060831 BonEcho/2.0b2 ID:2006083103 which includes that fix.
Summary: Back/Forward button's text is mis-aligned → Back/Forward Text is vertically misaligned in 'Icon and Text' mode
| Assignee | ||
Comment 5•20 years ago
|
||
Will get post-facto review on this.
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v <--
browser.cs
s
new revision: 1.17.2.49; previous revision: 1.17.2.48
done
Checking in browser/themes/winstripe/browser/browser.xml;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.xml,v <--
browser.xm
l
new revision: 1.4.8.6; previous revision: 1.4.8.5
done
| Assignee | ||
Updated•20 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Flags: blocking-firefox2?
Keywords: fixed1.8.1
Resolution: --- → FIXED
| Assignee | ||
Updated•20 years ago
|
Keywords: regression
Could this patch have screwed up the padding to the left of the back toolbar icon? It's too far to the left now!!!
~B
Doesn't matter whether you have small or large icons enabled or if you have icons and test.
(In reply to comment #7)
> Created an attachment (id=236343) [edit]
> Issue...
>
> Doesn't matter whether you have small or large icons enabled or if you have
> icons and test.
>
"icons and text" rather...
~B
| Assignee | ||
Comment 9•20 years ago
|
||
Checking in browser/themes/winstripe/browser/browser.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/browser.css,v <-- browser.cs
s
new revision: 1.17.2.50; previous revision: 1.17.2.49
done
| Assignee | ||
Comment 10•20 years ago
|
||
Comment on attachment 236234 [details] [diff] [review]
the fix
this code is gone.
Attachment #236234 -
Attachment is obsolete: true
Attachment #236234 -
Flags: review?(mconnor)
You need to log in
before you can comment on or make changes to this bug.
Description
•