350864 - Add ability to check news servers for new messages at startup

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[David :Bienvenu]

With the new folder views, we can't rely on checking news servers for new messages by simply expanding the news server in the folder pane. So we just need to turn on the ability to check news servers for new messages at startup. Patch upcoming.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

expose the pref UI for news servers and enable it in the backend.

Comment 2

[David :Bienvenu]

was that a slip of the mouse? this shouldn't have any l10n impact :-)

Comment 3

[Scott MacGregor]

Comment on attachment 236241 [details] [diff] [review]
proposed fix

yes it was :)

Comment 4

[David :Bienvenu]

fixed on trunk and 2.0 branch

Comment 5

[[e-mail]]

So does this make PerformExpandForAllOpenServers redundant?

Comment 6

[David :Bienvenu]

Neil, it does seem like that shouldn't be needed.

I don't ever seem to have my news servers expanded on startup, even if I expanded them in a previous session - is that just me?

Comment 7

[Adam Guthrie]

Apparently the "newsgroups not being expanded on startup" thing is controllable by a pref., news.persist_server_open_state_in_folderpane.

See bug 123029 (and the bugs mentioned in it) for more details. Is there really any reason to have this pref. now? It seems like we should just respect the last state of the folder...

Comment 8

[[e-mail]]

So given comment #6, should we use a) bug 123029 b) a related bug c) a new bug for each of the following changes:
1) Get rid of PerformExpandForAllOpenServers
2) Get rid of GetPersistElided (or make it return true)

Comment 9

[David :Bienvenu]

Let's use bug 123029 - the important thing is that we don't try to update the news groups because we expand the server, but rather because the user chose that setting in the server settings. We don't want double fetching of news group counts.

Comment 10

[Mike Cowperthwaite]

(In reply to comment #9)
> Let's use bug 123029 - the important thing is that we don't try to update the
> news groups because we expand the server, but rather because the user chose
> that setting in the server settings. We don't want double fetching of news
> group counts.

In my initial test of this (TB 3a1-0907), I find that expanding the server (in the regular folder tree-view) does, in fact, update the newsgroups.  This is true whether the newsserver is set to check at startup or not.  Is this as expected?  If not, is there already a bug about suppressing this?

Comment 11

[David :Bienvenu]

yes, expanding the news server has always updated the news counts, and is the only way for the user to immediately force the updates of all subscribed newsgroup counts on a server, other than waiting for the check for new messages interval.

Comment 12

[Karsten Düsterloh]

> In my initial test of this (TB 3a1-0907), I find that expanding the server (in
> the regular folder tree-view) does, in fact, update the newsgroups.

Actually, the usual behaviour is:
- on twisty click, expand and check news server
- on right arrow key hit, expand without checking news server
See bug 122006.

> This is true whether the newsserver is set to check at startup or not.

The startup pref just defines the behaviour for starting up with an expanded news server.

Comment 13

[Mike Cowperthwaite]

(In reply to comment #11)
> yes, expanding the news server has always updated the news counts, and is the
> only way for the user to immediately force the updates of all subscribed
> newsgroup counts on a server, other than waiting for the check for new
> messages interval.

OK; comment 9 can be read as saying "should not update newsgroups on server expansion" so I was looking for clarification.  btw, you can Get New Messages for a server or a newsgroup (F5/Ctrl+T/Get New toolbutton).

Comment 14

[Mike Cowperthwaite]

*** Bug 93809 has been marked as a duplicate of this bug. ***

Comment 15

[Mike Cowperthwaite]

*** Bug 320110 has been marked as a duplicate of this bug. ***

Comment 16

[David :Bienvenu]

I'm sorry, I should have said "expanding news server on startup, automatically, should not fetch counts" or something like that...