350874 - OnEndMsgDownload is no longer firing after message display (Phishing Bar Broken)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

On the trunk only, 

OnEndMsgDownload in http://lxr.mozilla.org/mozilla/source/mailnews/base/src/nsMsgStatusFeedback.cpp#172

is no longer getting called anymore. This means the phishing bar never gets set either. I probably broke this in Bug 345251.

Comment 1

[Scott MacGregor]

It looks like in:

nsMsgWindow::SetStatusFeedback

we are failing to find a docshell named "messagepane" in the docshell hierarchy:

http://lxr.mozilla.org/mozilla/source/mailnews/base/src/nsMsgWindow.cpp#184

as a result, we never register the status feedback object as a web progress listener on the message pane. Not sure why that's failing.

Comment 2

[Scott MacGregor]

Attachment: the fix

We were setting the status feedback object on the window before we set the dom window, and that's why in the call to SetStatusFeedback, we were unable to find a message pane docshell.

I added an assertion in nsMsgWindow::SetStatusFeedback to detect this pattern going forward, and I tweaked the callers in seamonkey and thunderbird.

Comment 3

[Scott MacGregor]

Fixed on the trunk only. 345251 is trunk only.

Comment 4

[Adam Guthrie]

I wonder if this fixes the crazy leaks I was seeing when debugging using the trace refcnt tools. I will try and do this and report back.