350963 - searchForm and iconUpdateURL parameters are not serialised in sherlock -> mozSearch conversion (icon update and searchForm usage fails for sherlock files after a restart)

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Mycroft Project (CC)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.8.0.6) Gecko/20060728 Firefox/1.5.0.6

As discussed...

When installing a sherlock .src file containing a searchForm parameter in Bon Echo, it is expected that the parameter will be copied to the mozSearch .xml file but it isn't.

Reproducible: Always

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Morphing this bug a little bit, I found another attribute that isn't saved to disk after installing a Sherlock plugin.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

SearchForm is being read but not written, IconUpdateUrl isn't being written at all, so it's lost after a restart.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

The exact effects of this bug are:

1) Icon updates don't work after installing a Sherlock plugin and restarting the browser.
2) Tools->Web Search or pressing enter in a blank search bar will not go to the correct location if a Sherlock engine specifies a searchForm and the browser is restarted after install.

Since the patch is simple, and introduces little to no risk of regression, I think this bug should block Firefox 2.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

I checked this in yesterday but forgot to mark the bug.

mozilla/browser/components/search/nsSearchService.js 	1.81

Comment 5

[Mike Connor [:mconnor]]

Comment on attachment 236355 [details] [diff] [review]
patch

a=mconnor on behalf of drivers for 1.8 branch checkin
straightforward, well-understood patch to be more compatible with 1.5 and earlier

Comment 6

[:Gavin Sharp [email: [e-mail]]]

mozilla/browser/components/search/nsSearchService.js 	1.1.2.65

Comment 7

[Mycroft Project (CC)]

This may not be the best place to ask...

Should this be working in either Fx2 nightlies or beta 2?

Because I still seem to be getting the old behaviour. I guess this is something to do with branches but if you could post a one liner to explain it to this ignoramus I would be grateful.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

Ugh, yes, this bug as summarized is fixed, but I just realized bug 352768 is not. I will fix and try to get that into tonight's builds.