351002 - Download options window points to a non-existing section; needs rewording

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[Ahmet Serkan Tıratacı]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; tr; rv:1.8.1b2) Gecko/20060831 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; tr; rv:1.8.1b2) Gecko/20060831 BonEcho/2.0b2

The file toolkit/locales/en-US/chrome/mozapps/downloads/unknownContentType.dtd needs rewording.

http://lxr.mozilla.org/mozilla1.8/source/toolkit/locales/en-US/chrome/mozapps/downloads/unknownContentType.dtd

Reproducible: Always

Steps to Reproduce:
1. Click on a file to download.
2. Download options windows is opened. Choose "Do this automatically for files like this from now on"
3. See "Settings can be changed in the Downloads section of..."

Actual Results:  
There's no download section in Firefox 2.

Expected Results:  
Wording should be this way: "Settings can be changed in the File Types section of..."

Comment 1

[Ahmet Serkan Tıratacı]

Attachment: rewording

Hope it works.

Comment 2

[Marek Stępień [:marcoos, inactive]]

As this is a late-l10n change, you have to change the entity names as well.

Comment 3

[Ahmet Serkan Tıratacı]

Attachment: patch with changed entity names

Comment 4

[Phil Ringnalda (:philor)]

And since the previous version was using "Downloads" as the name of the pref pane, not the section within the pane, you probably want to use "Content" in the new version - anyone who has gotten far enough to find "File Types" is already there.

Comment 5

[Ahmet Serkan Tıratacı]

Attachment: patch with "content" instead of "file types"

This is a patch that replaces "Downloads" with "Content".

I'm not sure who will decide, but let the suitable one be chosen from the two patches.

On the other hand, if my patches doesn't work, please feel free to create yours, as I have had problems with creating working patches.

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Ugh. This is my fault, and a post-l10n freeze issue. Fortunately, it's polish and not a blocker, though. Here's what I think we should do:

 - do the patch *without* revving entity names
 - notify l10n (hi, Axel!)
 - ask as many localizers to fix this as have time to do so
 - hit me next time you see me

Comment 7

[Phil Ringnalda (:philor)]

Attachment: Trunk patch

Trunk version, with changed entity names.

Comment 8

[Phil Ringnalda (:philor)]

Attachment: Fix

Branch stealth version, with unchanged entity names.

Comment 9

[Asaf Romano (gone)]

Comment on attachment 236920 [details] [diff] [review]
Fix

r=mano, eek.

Comment 10

[Asaf Romano (gone)]

Comment on attachment 236919 [details] [diff] [review]
Trunk patch

r=mano

Comment 11

[Phil Ringnalda (:philor)]

(In reply to comment #6)
>  - notify l10n (hi, Axel!)
>  - ask as many localizers to fix this as have time to do so

Posted to m.d.l10n

>  - hit me next time you see me

Hrm, how many localizers are there, and how easily do you bruise? Might want to skip FOSDEM for a few years.

Comment 12

[Axel Hecht [:Pike]]

I'm not sure if we would want to fork that file between trunk and branch, that sounds like just making things more painful.
Most localizers actually work on the branch only now and backport fixes to the trunk, so a fork is going to add extra work. Note, localizers may actually have fixed this bug independently of en-US in their locales.

Comment 13

[Phil Ringnalda (:philor)]

Comment on attachment 236920 [details] [diff] [review]
Fix

Well, just doing it one way certainly makes it simpler for whoever I talk into checking it in, so if that works for you it works for me.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 236920 [details] [diff] [review]
Fix

a=beltzner on behalf of 181drivers

The solution is to stealth change the string on both branch and trunk, not forking the file.

Comment 15

[Michael Wu [:mwu]]

Checking in toolkit/locales/en-US/chrome/mozapps/downloads/unknownContentType.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/unknownContentType.dtd,v  <--  unknownContentType.dtd
new revision: 1.6; previous revision: 1.5
done

Comment 16

[Michael Wu [:mwu]]

Branch:
Checking in toolkit/locales/en-US/chrome/mozapps/downloads/unknownContentType.dtd;
/cvsroot/mozilla/toolkit/locales/en-US/chrome/mozapps/downloads/unknownContentType.dtd,v  <--  unknownContentType.dtd
new revision: 1.3.10.2; previous revision: 1.3.10.1
done