35101 - HTMLInputElement.select() does not work

Status: VERIFIED FIXED

(Core :: Layout: Form Controls, defect, P3)

Description

[Simon Fraser [no longer active]]

The select() method on HTMLInputElement() does not work. It calls into 
nsHTMLInputElement::Select(), which calls

formControlFrame->SetProperty(presContext, nsHTMLAtoms::select, "");

on the nsGfxTextControlFrame, but this does nothing.

It seems to me that we should add selection-setting methods to 
nsIGfxTextControlFrame, and call them.

I'm looking at this because of bug 33967, which is related.

Comment 1

[Eric Pollmann]

Simon, you hit this one right on the head.  It made fixing it a cinch.  I
probably won't get a chance to get it in with some of the other nasty things I'm
trying to fix for M16, so setting Milestone to M17.

Comment 2

[Simon Fraser [no longer active]]

I have the fix in my tree. Taking bug.

Comment 3

[Eric Pollmann]

I have a fix in my tree too, as I mentioned above and wrote in the status 
whiteboard yesterday.  Does your fix look like mine?  Here's a patch (may be 
offset, lines added to nsGfxTextControlFrame::SetProperty):

Index: nsGfxTextControlFrame.cpp
===================================================================
RCS file: /cvsroot/mozilla/layout/html/forms/src/nsGfxTextControlFrame.cpp,v
retrieving revision 3.161
diff -r3.161 nsGfxTextControlFrame.cpp
1443a1418,1423
>       }
>     }
>     else if (nsHTMLAtoms::select == aName)
>     {
>       if (mEditor) {
>         mEditor->SelectAll();

If yours is equivalent, please feel free to mark it r=pollmann.

Comment 4

[Eric Pollmann]

Arg, I think I added yesterday's comment about not getting the fix in until M17 
to the wrong bug.  :S  I see why you grabbed this (I updated milestones on over 
50 bugs yesterday, guess I made at least one mistake).  At any rate the change 
is small, feel free to check it in.

Comment 5

[Simon Fraser [no longer active]]

No, my fix is a little more involved. I've added a method 
SetSelectionRange(PRInt32 start, PRInt32 end) to ns[I]GfxTextControlFrame, 
because I need to implement support for setting the selection specifically from 
JS (see bug 33967). So I have a bunch more code to go in, some of which fixes 
this bug.

Comment 6

[Simon Fraser [no longer active]]

I checked in a fix for this for both <input type="text">, and <textarea>

Comment 7

[Eric Pollmann]

Thanks Simon, you are 'da man'.  :)

Comment 8

[bsharma]

Updating QA contact.

Comment 9

[jerone]

Verified on build 2001-08-13-03T os:win98,win95,mac8.6