351050 - Arrow in searchbar drop down should be horizontally centered

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[Bryan]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060901 BonEcho/2.0b2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.1b2) Gecko/20060901 BonEcho/2.0b2

Chevron in searchbar drop down is not centered...

Reproducible: Always

Steps to Reproduce:
1) Launch FF
2) Observe chevron in searchbar drop down is not centered
Actual Results:  
Chevron in searchbar drop down is not centered...

Expected Results:  
Chevron in searchbar drop down is centered...

Comment 1

[Bryan]

Attachment: Lets center ourselves!

Comment 2

[Ria Klaassen (not reading all bugmail)]

Attachment: Even without arrow (space saving)

Comment 3

[Ria Klaassen (not reading all bugmail)]

Hm, if you have a screenshot, you have also a patch. Mine won't make it I think.

Comment 4

[Peter Kasting]

Things look vertically centered on my current branch build on Linux.  I can't tell whether the first image is a "before" or "after" image.  Can you do a split of current vs. proposed?

Comment 5

[Jackie Liu]

FYI, in the original mockup, the arrow was centered.  I don't see any obvious duplicate, so CONFIRMED.

Comment 6

[Bryan]

Attachment: This is current branch! Windows build...

Comment 7

[Bryan]

Attachment: This is what I propose and what the goal of this bug is!!!

Comment 8

[Bryan]

(In reply to comment #3)
> Hm, if you have a screenshot, you have also a patch. Mine won't make it I
> think.

Umm, no.  I did that in photoshop.

~B

Comment 9

[Adam Guthrie]

Attachment: Horizontally center the arrow (winstripe only)

I gave up trying to do a nice, zoomed before and after screenshot in The GIMP, so you're just going to have to trust me that this works.

Comment 10

[Asaf Romano (gone)]

Comment on attachment 236515 [details] [diff] [review]
Horizontally center the arrow (winstripe only)

r=mano

Comment 11

[Mike Schroepfer]

Comment on attachment 236515 [details] [diff] [review]
Horizontally center the arrow (winstripe only)

a=schrep for drivers for visual refresh cleanup.  We ui-review? this am -since that is done it should be ok for approval.

Comment 12

[Adam Guthrie]

I don't know if this is a problem on Winstripe (nor do I have a way to tell). If someone could report back on this or just send me a Mac that would be great.

Comment 13

[Bryan]

(In reply to comment #12)
> I don't know if this is a problem on Winstripe (nor do I have a way to tell).
> If someone could report back on this or just send me a Mac that would be great.

Adam,

Do you mean to say Pinstripe instead of Winstripe?

~B

Comment 14

[Adam Guthrie]

Yes.

Comment 15

[Martijn Wargers (dead)]

Checking in searchbar.css;
/cvsroot/mozilla/browser/themes/winstripe/browser/searchbar.css,v  <--  searchba
r.css
new revision: 1.3.8.17; previous revision: 1.3.8.16
done

Checked in on the 1.8.1 branch.

Comment 16

[ronin.achilles]

(In reply to comment #15)
> Checking in searchbar.css;
> /cvsroot/mozilla/browser/themes/winstripe/browser/searchbar.css,v  <-- 
> searchba
> r.css
> new revision: 1.3.8.17; previous revision: 1.3.8.16
> done
> 
> Checked in on the 1.8.1 branch.
> 

This bug is back in the latest build (09/14).

Comment 17

[Adam Guthrie]

Looks like Pam removed this rule in her checkin for bug 348138 / bug 351618.

Comment 18

[Pam Greene]

Attachment: Adds 1px to dropmarker margin

The structure of that binding got simpler as well.  I thought the arrow looked good nestled a little closer to the icon, so they appeared more connected, but it's a trivial change to move it a pixel over so it's more centered.

Comment 19

[Pam Greene]

Setting target so that this bug, which was nominated to block some time ago, shows up in the searches.

Comment 20

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 238462 [details] [diff] [review]
Adds 1px to dropmarker margin

r,uir,a=me :)

Comment 21

[Pam Greene]

Landing on 1.8.1 branch.

Comment 22

[Reed Loden [:reed]]

Clearing blocking request. Already fixed.